-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra][Hosts] Auto-refresh remains set when navigating to the Infra Hosts page #205414
Labels
bug
Fixes for quality problems that affect the customer experience
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
Comments
Bluefinger
added
bug
Fixes for quality problems that affect the customer experience
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
labels
Jan 2, 2025
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Bluefinger
added a commit
that referenced
this issue
Jan 3, 2025
…fresh (#205416) ## Summary A bug with the search bar configuration allows for a page that does not have auto-refresh enabled to inherit the auto-refresh state from another page that had previously enabled it. This PR fixes that by fully resetting the state for the page's search bar to ensure auto-refresh is not active for Hosts page (as it should be). Closes #205414 ## How to test - Go to Alerts page - Click on the Date Quick Selector, enable the auto-refresh feature. Confirm the refresh icon is on the datepicker now. - Navigate to Hosts page - The auto-refresh icon on the Hosts page search bar datepicker should no longer be visible, and opening the date quick selector should not show any auto-refresh feature/toggle.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Jan 3, 2025
…fresh (elastic#205416) ## Summary A bug with the search bar configuration allows for a page that does not have auto-refresh enabled to inherit the auto-refresh state from another page that had previously enabled it. This PR fixes that by fully resetting the state for the page's search bar to ensure auto-refresh is not active for Hosts page (as it should be). Closes elastic#205414 ## How to test - Go to Alerts page - Click on the Date Quick Selector, enable the auto-refresh feature. Confirm the refresh icon is on the datepicker now. - Navigate to Hosts page - The auto-refresh icon on the Hosts page search bar datepicker should no longer be visible, and opening the date quick selector should not show any auto-refresh feature/toggle. (cherry picked from commit d25dcc1)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Jan 3, 2025
…fresh (elastic#205416) ## Summary A bug with the search bar configuration allows for a page that does not have auto-refresh enabled to inherit the auto-refresh state from another page that had previously enabled it. This PR fixes that by fully resetting the state for the page's search bar to ensure auto-refresh is not active for Hosts page (as it should be). Closes elastic#205414 ## How to test - Go to Alerts page - Click on the Date Quick Selector, enable the auto-refresh feature. Confirm the refresh icon is on the datepicker now. - Navigate to Hosts page - The auto-refresh icon on the Hosts page search bar datepicker should no longer be visible, and opening the date quick selector should not show any auto-refresh feature/toggle. (cherry picked from commit d25dcc1)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Jan 3, 2025
…fresh (elastic#205416) ## Summary A bug with the search bar configuration allows for a page that does not have auto-refresh enabled to inherit the auto-refresh state from another page that had previously enabled it. This PR fixes that by fully resetting the state for the page's search bar to ensure auto-refresh is not active for Hosts page (as it should be). Closes elastic#205414 ## How to test - Go to Alerts page - Click on the Date Quick Selector, enable the auto-refresh feature. Confirm the refresh icon is on the datepicker now. - Navigate to Hosts page - The auto-refresh icon on the Hosts page search bar datepicker should no longer be visible, and opening the date quick selector should not show any auto-refresh feature/toggle. (cherry picked from commit d25dcc1)
kibanamachine
added a commit
that referenced
this issue
Jan 3, 2025
…auto-refresh (#205416) (#205504) # Backport This will backport the following commits from `main` to `8.16`: - [[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)](#205416) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-03T15:04:17Z","message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","Team:obs-ux-infra_services","v8.16.3","v8.17.1"],"title":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh","number":205416,"url":"https://github.com/elastic/kibana/pull/205416","mergeCommit":{"message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205416","number":205416,"mergeCommit":{"message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786"}},{"branch":"8.16","label":"v8.16.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gonçalo Rica Pais da Silva <[email protected]>
kibanamachine
added a commit
that referenced
this issue
Jan 3, 2025
…auto-refresh (#205416) (#205505) # Backport This will backport the following commits from `main` to `8.17`: - [[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)](#205416) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-03T15:04:17Z","message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","Team:obs-ux-infra_services","v8.16.3","v8.17.1"],"title":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh","number":205416,"url":"https://github.com/elastic/kibana/pull/205416","mergeCommit":{"message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205416","number":205416,"mergeCommit":{"message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786"}},{"branch":"8.16","label":"v8.16.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gonçalo Rica Pais da Silva <[email protected]>
kibanamachine
added a commit
that referenced
this issue
Jan 3, 2025
…uto-refresh (#205416) (#205506) # Backport This will backport the following commits from `main` to `8.x`: - [[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)](#205416) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-03T15:04:17Z","message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","Team:obs-ux-infra_services","v8.16.3","v8.17.1"],"title":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh","number":205416,"url":"https://github.com/elastic/kibana/pull/205416","mergeCommit":{"message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205416","number":205416,"mergeCommit":{"message":"[Infra][Hosts] Reset SearchBar refresh state to fully disable auto-refresh (#205416)\n\n## Summary\r\n\r\nA bug with the search bar configuration allows for a page that does not\r\nhave auto-refresh enabled to inherit the auto-refresh state from another\r\npage that had previously enabled it. This PR fixes that by fully\r\nresetting the state for the page's search bar to ensure auto-refresh is\r\nnot active for Hosts page (as it should be).\r\n\r\nCloses #205414 \r\n\r\n## How to test\r\n\r\n- Go to Alerts page\r\n- Click on the Date Quick Selector, enable the auto-refresh feature.\r\nConfirm the refresh icon is on the datepicker now.\r\n- Navigate to Hosts page\r\n- The auto-refresh icon on the Hosts page search bar datepicker should\r\nno longer be visible, and opening the date quick selector should not\r\nshow any auto-refresh feature/toggle.","sha":"d25dcc11ebdd18324111fc7dc403014b08fbf786"}},{"branch":"8.16","label":"v8.16.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gonçalo Rica Pais da Silva <[email protected]>
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this issue
Jan 7, 2025
…fresh (elastic#205416) ## Summary A bug with the search bar configuration allows for a page that does not have auto-refresh enabled to inherit the auto-refresh state from another page that had previously enabled it. This PR fixes that by fully resetting the state for the page's search bar to ensure auto-refresh is not active for Hosts page (as it should be). Closes elastic#205414 ## How to test - Go to Alerts page - Click on the Date Quick Selector, enable the auto-refresh feature. Confirm the refresh icon is on the datepicker now. - Navigate to Hosts page - The auto-refresh icon on the Hosts page search bar datepicker should no longer be visible, and opening the date quick selector should not show any auto-refresh feature/toggle.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this issue
Jan 13, 2025
…fresh (elastic#205416) ## Summary A bug with the search bar configuration allows for a page that does not have auto-refresh enabled to inherit the auto-refresh state from another page that had previously enabled it. This PR fixes that by fully resetting the state for the page's search bar to ensure auto-refresh is not active for Hosts page (as it should be). Closes elastic#205414 ## How to test - Go to Alerts page - Click on the Date Quick Selector, enable the auto-refresh feature. Confirm the refresh icon is on the datepicker now. - Navigate to Hosts page - The auto-refresh icon on the Hosts page search bar datepicker should no longer be visible, and opening the date quick selector should not show any auto-refresh feature/toggle.
viduni94
pushed a commit
to viduni94/kibana
that referenced
this issue
Jan 23, 2025
…fresh (elastic#205416) ## Summary A bug with the search bar configuration allows for a page that does not have auto-refresh enabled to inherit the auto-refresh state from another page that had previously enabled it. This PR fixes that by fully resetting the state for the page's search bar to ensure auto-refresh is not active for Hosts page (as it should be). Closes elastic#205414 ## How to test - Go to Alerts page - Click on the Date Quick Selector, enable the auto-refresh feature. Confirm the refresh icon is on the datepicker now. - Navigate to Hosts page - The auto-refresh icon on the Hosts page search bar datepicker should no longer be visible, and opening the date quick selector should not show any auto-refresh feature/toggle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
Kibana version: 8.14.3
Describe the bug:
The Hosts page in Infrastructure does not have auto-refresh enabled for perf reasons, given the amount of data needed to load the page. However, if on other pages with auto-refresh capability, if the search bar is set to auto-refresh periodically, upon navigating from the auto-refreshing page to the Hosts page, the auto-refresh setting will remain enabled and work for Hosts, even though the facility to change/disable it is not there.
Steps to reproduce:
Expected behavior:
The Auto-refresh setting should reset and no longer apply on the Hosts page, with no refreshes occurring periodically.
Actual behaviour:
The auto-refresh icon is still visible on the datepicker in the Hosts page, and the page refreshes periodically.
Screenshots (if relevant):
Acceptance Criteria
The text was updated successfully, but these errors were encountered: