Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Ability to undo actions #23614

Closed
ryankeairns opened this issue Sep 28, 2018 · 5 comments
Closed

[Canvas] Ability to undo actions #23614

ryankeairns opened this issue Sep 28, 2018 · 5 comments
Labels
enhancement New value added to drive a business result Feature:Canvas loe:medium Medium Level of Effort Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ryankeairns
Copy link
Contributor

Describe the feature:
I would like the basic ability to undo recent actions.

Describe a specific use case for the feature:
For example, I delete or move an element and want to bring it back to its previous state using command-z/ctrl-z or some similar action.

Implementation-wise the deletion undo could be split to 3 things:

a) what affordance / gesture to use (now Backspace, in the future, ctrl-z),
b) how to help feature discovery (eg. what you or I wrote),
c) how to make the experience smoother, despite Redux

@ryankeairns ryankeairns added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Sep 28, 2018
@monfera
Copy link
Contributor

monfera commented Sep 28, 2018

Meta issue: #23058

From our slack convo: it'd be good to avoid a confirmation dialog - as it's a modal thing (nomodes!) but maybe at some point we could add a transient annotation near the element, or somewhere on the side, showing what happened:

❌ element deleted... [click to undo]

so an affordance that

  1. doesn't remove normal controls from other elements,
  2. small but salient, doesn't occlude other things, and most importantly, doesn't add a fadeout screen over the entire thing,
  3. it has a timeout and gets removed from the DOM after transitioning its opacity to zero

@rashidkpc
Copy link
Contributor

This is currently implemented by the back and forward buttons in the browser, but it would be nice to wire them up to buttons and keyboard shortcuts

@stacey-gammon stacey-gammon added the enhancement New value added to drive a business result label Oct 2, 2018
@ryankeairns ryankeairns added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Nov 12, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design

@cqliu1
Copy link
Contributor

cqliu1 commented Apr 30, 2019

They both have shortcuts:
undo: cmd/ctrl+z
redo: cmd/ctrl+shift+z

I think all that's left is to add undo/redo buttons somewhere in the UI.

@cqliu1 cqliu1 added the loe:medium Medium Level of Effort label Apr 30, 2019
@ryankeairns
Copy link
Contributor Author

I'm ok with just closing this issue. This particular action feels common enough that, as long as we're using the common shortcuts (which we are), that users will discover it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Canvas loe:medium Medium Level of Effort Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

7 participants