Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move src/legacy/utils/kbn_field_types to data plugin #44186

Closed
4 tasks done
lukeelmers opened this issue Aug 27, 2019 · 1 comment · Fixed by #46565
Closed
4 tasks done

Move src/legacy/utils/kbn_field_types to data plugin #44186

lukeelmers opened this issue Aug 27, 2019 · 1 comment · Fixed by #46565
Assignees
@alexwizp
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:NP Migration

Comments

@lukeelmers
Copy link
Member

lukeelmers commented Aug 27, 2019 •
edited by streamich
Loading

  • Convert kbn_field_types.js to TS
  • Convert __tests__/kbn_field_types.js to Jest & TS
  • Move kbn_field_types to data plugin (can be exported statically)
  • Export from legacy location in src/legacy/utils for backwards compatibility

Part of #43438
@lukeelmers lukeelmers added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:AppArch Feature:NP Migration labels Aug 27, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@streamich streamich mentioned this issue Aug 27, 2019
Closed
9 tasks
@alexwizp alexwizp mentioned this issue Sep 25, 2019
Merged
11 tasks
alexwizp added a commit to alexwizp/kibana that referenced this issue Sep 25, 2019
@alexwizp
Move src/legacy/utils/kbn_field_types to data plugin
278e7f6 
Fix: elastic#44186
alexwizp added a commit that referenced this issue Sep 26, 2019
@alexwizp
Move src/legacy/utils/kbn_field_types to data plugin (#46565)
e0a3dc5 
* Move `src/legacy/utils/kbn_field_types` to data plugin

Fix: #44186

* fix CI
alexwizp added a commit to alexwizp/kibana that referenced this issue Sep 26, 2019
@alexwizp
Move src/legacy/utils/kbn_field_types to data plugin (elastic#46565)
a696efa 
* Move `src/legacy/utils/kbn_field_types` to data plugin

Fix: elastic#44186

* fix CI
alexwizp added a commit that referenced this issue Sep 26, 2019
@alexwizp
Move src/legacy/utils/kbn_field_types to data plugin (#46565) (#46695)
32efbf1 
* Move `src/legacy/utils/kbn_field_types` to data plugin

Fix: #44186

* fix CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:NP Migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move src/legacy/utils/kbn_field_types to data plugin alexwizp/kibana
3 participants
@lukeelmers @elasticmachine @alexwizp