Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade to query-string v5.1.1 #58684

Closed
joshdover opened this issue Feb 27, 2020 · 1 comment · Fixed by #59633
Closed

Downgrade to query-string v5.1.1 #58684

joshdover opened this issue Feb 27, 2020 · 1 comment · Fixed by #59633
Assignees
@alexwizp
Labels
blocker bug Fixes for quality problems that affect the customer experience IE11 loe:small Small Level of Effort v7.7.0

Comments

@joshdover
Copy link
Contributor

In #56957, query-string 6.x was added, which does not support IE11. This needs to be downgraded in master and 7.x before the next release.
@joshdover joshdover added bug Fixes for quality problems that affect the customer experience blocker IE11 Team:AppArch v7.7.0 labels Feb 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@joshdover joshdover mentioned this issue Feb 27, 2020
Closed
@lukeelmers lukeelmers added the loe:small Small Level of Effort label Feb 27, 2020
@alexwizp alexwizp mentioned this issue Feb 28, 2020
Closed
7 tasks
alexwizp added a commit to alexwizp/kibana that referenced this issue Feb 28, 2020
@alexwizp
[IE11] Kibana doesn't transpile correctly in development mode
d6d33ed 
Closes: elastic#58684
@wylieconlon wylieconlon mentioned this issue Feb 28, 2020
Closed
2 tasks
@lukeelmers lukeelmers mentioned this issue Feb 28, 2020
Closed
lukeelmers added a commit to lukeelmers/kibana that referenced this issue Feb 28, 2020
@lukeelmers
POC - Export query-string as @kbn/query-string
968afe9 
Fixes elastic#58684.

In elastic#56957 we consolidated usage of various query string utils by using
the `query-string` dependency everywhere. Unfortunately, this introduced
a regression where Kibana failed in IE11 due to dropped IE support as of
`query-string` v6.0.0. Downgrading is not an easy option due to changed
APIs and lack of type definitions.

This POC experiments with the idea of requiring the original
`query-string` package, copying the files into this package, and running
them through babel.

As a result, plugins can use `@kbn/query-string` as a drop-in
replacement for `query-string`, the only difference being that the
upstream library has now been transpiled.
@alexwizp alexwizp mentioned this issue Mar 9, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
blocker bug Fixes for quality problems that affect the customer experience IE11 loe:small Small Level of Effort v7.7.0
Projects
None yet
Milestone
No milestone
4 participants
@lukeelmers @joshdover @elasticmachine @alexwizp