Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest] Update PackageIcon component to use empty icon during initialization #60622

Closed
paul-tavares opened this issue Mar 19, 2020 · 3 comments
Closed

[Ingest] Update PackageIcon component to use empty icon during initialization #60622

paul-tavares opened this issue Mar 19, 2020 · 3 comments
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@paul-tavares
Copy link
Contributor

Add empty as the initial icon to be displayed to the PackageIcon component (x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/package_icon.tsx:28)

Background

With PR #60429, a PackageIcon component was created that will attempt to show a package's icon (if available) or revert back to a Eui icon if one is not defined. This component should display the Eui empty icon while it is trying to determine if a package icon exists. This effort uncovered a bug in EuiIcon (ref: elastic/eui/pull/3118 ) which in turn cause us to remove the use of the empty icon.
EuiIcon bug fix should be available by Feb. 27, 2020
@paul-tavares paul-tavares added Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project labels Mar 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
@paul-tavares paul-tavares mentioned this issue Apr 1, 2020
Merged
@ph
Copy link
Contributor

ph commented May 25, 2020

@paul-tavares For fixing this is just adding the empty icon back?

@paul-tavares
Copy link
Contributor Author

@ph sorry - I thought I had sent a reply on this already.
I think that is all this is for and the required changes on the Eui side should have gone in already

@ph ph closed this as completed Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ph @jen-huang @elasticmachine @paul-tavares