[EPM] Share package icon location hook

[jfsiii]

Summary

Moved the hook which determines the icon to show for a package to top-level hooks so it can be shared by other components.

Removed code to call HTTP API if an icon couldn't be found.

See commit messages for more information.

Current

PR

[elasticmachine]

Pinging @elastic/ingest-management (Feature:EPM)

[paul-tavares]

Question: I see that the API call was removed - will this component still display the correct/expected icon in cases where this it is used with only props packageName and version? (this is (was?) the case in the Agent Config > Datasources list)

[jfsiii]

@paul-tavares thanks for the context about the API call. I thought it was from the time when registry only gave icon paths for /search but not /package (or vice versa?). I'll look at config > datasources list and adjust

[paul-tavares]

np @jfsiii - it was one of my last contributions to Ingest, so its still fresh in my mind 😃 .
you might still see an icon in the datasouces table, but it might not be the expected one (it might be the one from Eui logo*;

[jfsiii]

@paul-tavares Do you mean these views?

If so, things look good to me. IIUC those views use useGetPackages and useGetPackageInfoByKey to hit EPM's API, so it has icons property

[paul-tavares]

Sorry for the delay. The view for adding datasource (second screen capture) does have the `icons` info. (uses epm APIs) if I remember correctly. The view shown under the Agent Config > `datasources` uses the datasources api which, unless changed recently, does not have the `icons` object under the `package` information. I can give it a closer look tomorrow tomorrow.

…

--

___ *Paul Tavares *| Sr. Software Engineer | Elastic / www.elastic.co | Durham, NC, USA

[jfsiii]

@paul-tavares I was trying to show that activemq, cockroachdb, and other integrations without EUI logos work.

However, it seems to only occur if you've gone through the setup. Hard refresh or starting on that view uses default icon.

I'll update the code one way or another and ping you after.

[paul-tavares]

@jfsiii ahhh. sorry about that - did not realize that was the intent 😄
Yeah, that makes sense - if you go through the setup (or add datasource flow) at least once, the icons will be loaded using the icons object and cached, so subsequent uses will just use the cached value.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: f93d4b6

History

• 💚 Build #38277 succeeded 5c3b0cd
• 💚 Build #37670 succeeded 0a0a319

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[paul-tavares]

LGTM 👍

[kibanamachine]

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 62072 or prevent reminders by adding the backport:skip label.