Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete legacy embeddable_api plugin #61545

Closed
3 tasks done
lukeelmers opened this issue Mar 26, 2020 · 1 comment · Fixed by #61767
Closed
3 tasks done

Delete legacy embeddable_api plugin #61545

lukeelmers opened this issue Mar 26, 2020 · 1 comment · Fixed by #61767
Assignees
@alexwizp
Labels
chore Feature:Embedding Embedding content via iFrame Feature:NP Migration

Comments

@lukeelmers
Copy link
Member

lukeelmers commented Mar 26, 2020 •
edited
Loading

Part of #51560

Currently src/legacy/core_plugins/embeddable_api is basically doing nothing besides re-exporting the static public contract of the embeddable plugin. We should delete it to clean things up.

  • remove core_plugins/embeddable_api
  • update static imports referencing embeddable_api to pull from the new platform plugin
  • add Dev Docs note to PR to make sure 3rd party devs who may have been depending on that plugin are aware it has been relocated
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers lukeelmers mentioned this issue Mar 26, 2020
Closed
40 tasks
alexwizp added a commit to alexwizp/kibana that referenced this issue Mar 30, 2020
@alexwizp
Delete legacy embeddable_api plugin
2d2a900 
Closes: elastic#61545
@alexwizp alexwizp mentioned this issue Mar 30, 2020
Merged
2 tasks
alexwizp added a commit that referenced this issue Mar 31, 2020
@alexwizp
Delete legacy embeddable_api plugin (#61767)
1696dd5 
* Delete legacy `embeddable_api` plugin

Closes: #61545

* fix test:karma
alexwizp added a commit to alexwizp/kibana that referenced this issue Mar 31, 2020
@alexwizp
Delete legacy embeddable_api plugin (elastic#61767)
9e6131c 
* Delete legacy `embeddable_api` plugin

Closes: elastic#61545

* fix test:karma
alexwizp added a commit that referenced this issue Mar 31, 2020
@alexwizp
Delete legacy embeddable_api plugin (#61767) (#61930)
27afc15 
* Delete legacy `embeddable_api` plugin

Closes: #61545

* fix test:karma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
chore Feature:Embedding Embedding content via iFrame Feature:NP Migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete legacy embeddable_api plugin alexwizp/kibana
3 participants
@lukeelmers @elasticmachine @alexwizp