Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Vega Editor the UI tool for creating and managing Vega visualizations #68455

Closed
eddieturizo opened this issue Jun 5, 2020 · 10 comments
Labels
discuss enhancement New value added to drive a business result Feature:Vega Vega visualizations feedback_needed Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@eddieturizo
Copy link

Describe the feature:

Make the Vega Editor the UI tool for creating and managing Vega visualizations.

Describe a specific use case for the feature:

The current version of Kibana throws you in to the Console (Dev Tools) as part of creating a Vega visualization. The Vega Editor seems more user friendly which may allow for increased user adoption.

@eddieturizo eddieturizo added the Feature:Vega Vega visualizations label Jun 5, 2020
@nathanrstacey nathanrstacey pinned this issue Jun 8, 2020
@nathanrstacey
Copy link

I want to second this request. It would be a huge value-add to Vega users and make the existing features more usable and thus more used. From my experience, power users love Vega

@timroes timroes added enhancement New value added to drive a business result intent-discuss Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes
Copy link
Contributor

timroes commented Jun 8, 2020

Could you please clarify whatyo mean by "throwing you into the Console". The console in the dev tools is not related to Vega visualization at all. Do you mean by it, that the UI looks similar between those? Or do you mean, that you're creating custom requests within Vega?

@timroes
Copy link
Contributor

timroes commented Jun 8, 2020

Could you please also clarify: Which parts of the Vega editor are the ones you are missing? Since a Vega spec is primarily that JSON input, both Vega editor as the current vega editor in Kibana are giving the user an input on that, so I would be curious on what parts of the linked Vega editor are the ones that you are missing?

@eddieturizo
Copy link
Author

Could you please clarify whatyo mean by "throwing you into the Console".

I was mistaken and thought it was Dev Tools (Console). I traced my steps both in 7.6.0 and 7.7.0 and can confirm that I am not thrown in to Dev Tools. Sorry for the confusion.

@eddieturizo
Copy link
Author

Which parts of the Vega editor are the ones you are missing? Since a Vega spec is primarily that JSON input, both Vega editor as the current vega editor in Kibana are giving the user an input on that, so I would be curious on what parts of the linked Vega editor are the ones that you are missing?

I'm sorry, I do not follow the questions here as I do not see where I refer to missing features. Would you mind clarifying?

@alexfrancoeur alexfrancoeur unpinned this issue Jun 8, 2020
@timroes
Copy link
Contributor

timroes commented Jun 9, 2020

You're suggesting that we should use the Vega sample editor to edit vega visualizations in Kibana. Basically any vega editor is just a textbox that let you enter the Vega spec. Also the Vega sample editor is nothing you can embed somewhere, so we won't use it in Kibana.

So I am trying to understand, what features from the Vega sample editor are the ones that you are missing in the Kibana Vega editor to see what enhancements to the Kibana Vega editor you're actually hoping for by the suggestion of "using the Vega sample editor" inside Kibana. It would be helpful if you could list a couple of features in that editor that you're missing in Kibana, that you were hoping to have (and where that request is originating from).

@eddieturizo
Copy link
Author

https://vega.github.io/editor/#/edited and then click on the caret-like symbol/icon which exposes Logs, Data Viewer, and Signal Viewer.

There is a desire to have that visual functionality of viewing the signals, logs and data instead of having to go into Chrome Dev Tools and using VEGA_DEBUG in the console to find the data.

In the Kibana Vega editor, we expose "Format and remove comments". It would be nice to have "Format and not remove comments".

@nimocks
Copy link

nimocks commented Jun 9, 2020

The current method to debug Vega is found on https://www.elastic.co/guide/en/kibana/current/vega-debugging.html which is not user friendly.

If I want to see what values are in my data and signals I have to open the dev console in chrome and go through VEGA_DEBUG object to locate it.

In the github editor (https://vega.github.io/editor/#/edited) it has a UI so there is no need for any of that. Bringing the debug functionality out of the dev console and into the UI will make the Kiban Vega editor more user friendly.

@timroes
Copy link
Contributor

timroes commented Jul 1, 2020

Closing this as a duplicate of:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss enhancement New value added to drive a business result Feature:Vega Vega visualizations feedback_needed Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

6 participants