Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inspector to Vega vis #31189

Closed
nyurik opened this issue Feb 14, 2019 · 5 comments · Fixed by #70941
Closed

Add inspector to Vega vis #31189

nyurik opened this issue Feb 14, 2019 · 5 comments · Fixed by #70941
Assignees
@monfera @alexwizp
Labels
Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@nyurik
Copy link
Contributor

nyurik commented Feb 14, 2019

When developing a Vega visualization it is paramount to be able to view the underlying data in the different stages of processing by Vega language. Data inspector is a perfect fit, but it is not being supported by Vega at the moment. We should add the following capabilities to the inspect view:

  • View the state of the data sources after all transformations have been applied. This is the same data as viewable from the browser debug console with VEGA_DEBUG.view.data('<source name>'). The standalone Vega editor already implements it in this way:
    image
  • View all ES requests made by Vega (stats/request/response). This is probably a bit less critical than the data viewer, but highly useful nevertheless.
  • We may want to support other internal Vega state such as signal values.

See Vega debugging API.
@nyurik nyurik added Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 14, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes timroes mentioned this issue May 8, 2019
Closed
@monfera monfera self-assigned this Sep 20, 2019
@monfera
Copy link
Contributor

monfera commented Sep 20, 2019

Assigned after a convo with @timroes

@alexwizp
Copy link
Contributor

hey @monfera , if you don't mind I also would like to work on that.

@alexwizp alexwizp self-assigned this Jul 1, 2020
@timroes timroes changed the title Add data inspector to Vega vis Add inspector to Vega vis Jul 1, 2020
@timroes
Copy link
Contributor

timroes commented Jul 1, 2020

I'll add to this, the most useful things we currently most likely want in the custom inspector panel:

  • View the compiled Vega specification
  • View the data tables
  • View other information (e.g. signals, like in the editor), the debugging API documentation has a couple of useful explanations in there

@timroes timroes mentioned this issue Jul 1, 2020
Closed
@nimocks
Copy link

nimocks commented Jul 1, 2020

Would also be nice to see the elastic data API calls/responses in this inspector UI on top of what Vega debug can offer.

@alexwizp alexwizp mentioned this issue Jul 7, 2020
Merged
7 tasks
alexwizp added a commit to alexwizp/kibana that referenced this issue Jul 8, 2020
@alexwizp
[WIP] Add inspector for VEGA
009fdcc 
Closes: elastic#31189
alexwizp added a commit that referenced this issue Jul 21, 2020
@alexwizp @elasticmachine @wylieconlon
Add inspector for VEGA (#70941)
e1ffccc 
* [WIP] Add inspector for VEGA

Closes: #31189

* view -> dataset

* cleanup

* add spec viewer

* cleanup code

* use rx to retrieve data from adapters

* Make custom inspector adapters registerable from the visType

* fix flex-box size

* cleanup

* remove visTypesWithoutInspector from visualize_embeddable

* fix PR comments

* add vega folder to sass-lint

* fix jest

* Update src/plugins/vis_type_vega/public/vega_inspector/components/data_viewer.tsx

Co-authored-by: Wylie Conlon <[email protected]>

* use addSignalListener

* cleanup

* add onColumnResize handler

* EuiCodeEditor -> CodeEditor

* fix type_check

* fix issue with pagination

* fix extra vertical scroll

* add area-label for EuiButtonIcon

* add area-label for EuiComboBox

* Design Commit

- Fixing up layout trying to remove any `.eui` classes and uses flex instead of percentage
- Fixing text to use `Sentence case` not `Title Case`

* Wrapper around signal viewer table

* fix Jest snapshot

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Wylie Conlon <[email protected]>
Co-authored-by: cchaos <[email protected]>
alexwizp added a commit to alexwizp/kibana that referenced this issue Jul 21, 2020
@alexwizp @elasticmachine @wylieconlon
Add inspector for VEGA (elastic#70941)
ce7fa59 
* [WIP] Add inspector for VEGA

Closes: elastic#31189

* view -> dataset

* cleanup

* add spec viewer

* cleanup code

* use rx to retrieve data from adapters

* Make custom inspector adapters registerable from the visType

* fix flex-box size

* cleanup

* remove visTypesWithoutInspector from visualize_embeddable

* fix PR comments

* add vega folder to sass-lint

* fix jest

* Update src/plugins/vis_type_vega/public/vega_inspector/components/data_viewer.tsx

Co-authored-by: Wylie Conlon <[email protected]>

* use addSignalListener

* cleanup

* add onColumnResize handler

* EuiCodeEditor -> CodeEditor

* fix type_check

* fix issue with pagination

* fix extra vertical scroll

* add area-label for EuiButtonIcon

* add area-label for EuiComboBox

* Design Commit

- Fixing up layout trying to remove any `.eui` classes and uses flex instead of percentage
- Fixing text to use `Sentence case` not `Title Case`

* Wrapper around signal viewer table

* fix Jest snapshot

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Wylie Conlon <[email protected]>
Co-authored-by: cchaos <[email protected]>
alexwizp added a commit that referenced this issue Jul 21, 2020
@alexwizp @elasticmachine @wylieconlon
Add inspector for VEGA (#70941) (#72625)
1e1db32 
* [WIP] Add inspector for VEGA

Closes: #31189

* view -> dataset

* cleanup

* add spec viewer

* cleanup code

* use rx to retrieve data from adapters

* Make custom inspector adapters registerable from the visType

* fix flex-box size

* cleanup

* remove visTypesWithoutInspector from visualize_embeddable

* fix PR comments

* add vega folder to sass-lint

* fix jest

* Update src/plugins/vis_type_vega/public/vega_inspector/components/data_viewer.tsx

Co-authored-by: Wylie Conlon <[email protected]>

* use addSignalListener

* cleanup

* add onColumnResize handler

* EuiCodeEditor -> CodeEditor

* fix type_check

* fix issue with pagination

* fix extra vertical scroll

* add area-label for EuiButtonIcon

* add area-label for EuiComboBox

* Design Commit

- Fixing up layout trying to remove any `.eui` classes and uses flex instead of percentage
- Fixing text to use `Sentence case` not `Title Case`

* Wrapper around signal viewer table

* fix Jest snapshot

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Wylie Conlon <[email protected]>
Co-authored-by: cchaos <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Wylie Conlon <[email protected]>
Co-authored-by: cchaos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monfera monfera

@alexwizp alexwizp

Labels
Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add inspector for VEGA alexwizp/kibana
6 participants
@timroes @monfera @nyurik @nimocks @elasticmachine @alexwizp