Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Breadcrumb Navigation Container #7393

Closed
pickypg opened this issue Jun 8, 2016 · 2 comments
Closed

Create Breadcrumb Navigation Container #7393

pickypg opened this issue Jun 8, 2016 · 2 comments
Assignees
Labels
release_note:enhancement Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@pickypg
Copy link
Member

pickypg commented Jun 8, 2016

The impetus came from #7380. Currently, it's up to plugins to create the breadcrumb navigation and do it properly themselves.

This can only lead to different implementations and therefore different styles, which will detract from the overall experience when jumping from plugin-to-plugin, as well as make plugin development a small-bit harder when trying to match the native experience (and even official plugins face this burden).

We should encapsulate this behavior in Kibana itself so that pages can establish their breadcrumbs and tabs or title, as well as which tab is currently selected. In doing so, this can help us to establish certain rules that keep the behavior both looking and feeling consistent.

Some rules that need to be maintained:

  • When displaying tabs, they all need to have a link.
  • Tabs need to be limited to a reasonable (aka arbitrary, but small) number.
  • Which tab is active (required).
  • Titles (aka singular tabs) should not have links.
  • You cannot have both a title and tabs.
  • Breadcrumbs should not include the tabs (thus hopefully implying that they're actually breadcrumbs).

From there, we can take those inputs and build the entire top bar, possibly including a capacity to add both custom and non-custom, but optional content to it (e.g., the pause/play and time controls currently live there).

@epixa epixa added the P1 label Jun 9, 2016
@cjcenizal cjcenizal self-assigned this Jun 30, 2016
@epixa epixa removed the P1 label Apr 25, 2017
@timroes timroes added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Aug 13, 2018
@timroes
Copy link
Contributor

timroes commented Aug 13, 2018

cc @elastic/kibana-platform @elastic/kibana-design I think that issue might be outdated with regards to the new K7 design. Could someone approve on that and close it?

@snide
Copy link
Contributor

snide commented Aug 13, 2018

Correct. This is mostly laid out through the introduction of the header in the K7 designs.

https://elastic.github.io/eui/#/layout/header

@snide snide closed this as completed Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

No branches or pull requests

5 participants