Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long transaction names overlap table #73960

Closed
smith opened this issue Jul 31, 2020 · 1 comment · Fixed by #76083
Closed

Long transaction names overlap table #73960

smith opened this issue Jul 31, 2020 · 1 comment · Fixed by #76083
Assignees
@smith
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support

Comments

@smith
Copy link
Contributor

smith commented Jul 31, 2020

Transactions with long names can overlap the rest of the columns on the table, especially at lower resolutions:

image

Truncate these so this doesn't happen.
@smith smith added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support labels Jul 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith smith self-assigned this Aug 26, 2020
smith added a commit to smith/kibana that referenced this issue Aug 27, 2020
@smith
[APM] Fix overlapping transaction names
1ef000e 
...in the table and the header. Did this by adding `word-break: break-all` to them.

Also:

* Rename List to TransactionList
* Add stories for TransactionList and ApmHeader
* Add missing type information to transactions based on sample transaction
*
Fixes elastic#73960.
smith added a commit to smith/kibana that referenced this issue Aug 27, 2020
@smith
[APM] Fix overlapping transaction names
a351b8b 
...in the table and the header. Did this by adding `word-break: break-all` to them.

Also:

* Rename List to TransactionList
* Add stories for TransactionList and ApmHeader
* Add missing type information to transactions based on sample transaction
*
Fixes elastic#73960.
@smith smith mentioned this issue Aug 27, 2020
Merged
@smith smith closed this as completed in 2486a71 Aug 31, 2020
smith added a commit to smith/kibana that referenced this issue Aug 31, 2020
@smith
[APM] Language-specific stacktrace formatting (elastic#75924)
b11b942 
* [APM] Language-specific stacktrace formatting

* Add todos

* more

* add at prefix for java

* [APM] Fix overlapping transaction names

...in the table and the header. Did this by adding `word-break: break-all` to them.

Also:

* Rename List to TransactionList
* Add stories for TransactionList and ApmHeader
* Add missing type information to transactions based on sample transaction
*
Fixes elastic#73960.
# Conflicts:
#	x-pack/plugins/apm/typings/es_schemas/raw/error_raw.ts
smith added a commit that referenced this issue Sep 4, 2020
@smith
[APM] Fix overlapping transaction names (#76083)
4d4eae4 
...in the table and the header. Did this by adding `word-break: break-all` to them.

Also:

* Rename List to TransactionList
* Add stories for TransactionList and ApmHeader
* Add missing type information to transactions based on sample transaction

Fixes #73960.
smith added a commit to smith/kibana that referenced this issue Sep 8, 2020
@smith
[APM] Fix overlapping transaction names (elastic#76083)
67727f8 
...in the table and the header. Did this by adding `word-break: break-all` to them.

Also:

* Rename List to TransactionList
* Add stories for TransactionList and ApmHeader
* Add missing type information to transactions based on sample transaction

Fixes elastic#73960.
# Conflicts:
#	x-pack/plugins/apm/typings/es_schemas/raw/fields/host.ts
#	x-pack/plugins/apm/typings/es_schemas/raw/fields/service.ts
smith added a commit that referenced this issue Sep 8, 2020
@smith
[APM] Fix overlapping transaction names (#76083) (#76945)
0241423 
...in the table and the header. Did this by adding `word-break: break-all` to them.

Also:

* Rename List to TransactionList
* Add stories for TransactionList and ApmHeader
* Add missing type information to transactions based on sample transaction

Fixes #73960.
# Conflicts:
#	x-pack/plugins/apm/typings/es_schemas/raw/fields/host.ts
#	x-pack/plugins/apm/typings/es_schemas/raw/fields/service.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smith smith

Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Fix overlapping transaction names smith/kibana
4 participants
@smith @ogupte @formgeist @elasticmachine