Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global search does not work #82222

Closed
liza-mae opened this issue Oct 31, 2020 · 8 comments · Fixed by #82252
Closed

Global search does not work #82222

liza-mae opened this issue Oct 31, 2020 · 8 comments · Fixed by #82252
Labels
blocker bug Fixes for quality problems that affect the customer experience REASSIGN from Team:Core UI Deprecated label for old Core UI team v7.10.0

Comments

@liza-mae
Copy link
Contributor

liza-mae commented Oct 31, 2020 •
edited
Loading

Kibana version: 7.10.0 BC4

Elasticsearch version: 7.10.0 BC4

Server OS version: Ubuntu

Browser version: Chrome Latest

Original install method (e.g. download page, yum, from source, etc.):
Staging

Description of the problem including expected versus actual behavior:
Using search menu results in error and search box disappearing.

Steps to reproduce:

  1. Install Es and Kibana
  2. Enter search term in box, click enter. Observe error occurs and box disappears.

Errors in browser console (if relevant):

kbn-ui-shared-deps.js:434 Uncaught TypeError: key.toLowerCase(...).replaceAll is not a function
    at Object.onChange (globalSearchBar.plugin.js:2)
    at [email protected]:912
    at r.onAddOption ([email protected]:912)
    at u.<anonymous> ([email protected]:912)
    at yo (kbn-ui-shared-deps.js:434)
    at bo (kbn-ui-shared-deps.js:434)
    at bl (kbn-ui-shared-deps.js:434)
    at t.unstable_runWithPriority (kbn-ui-shared-deps.js:442)
    at Hi (kbn-ui-shared-deps.js:434)
    at vl (kbn-ui-shared-deps.js:434)

Screenshot from 2020-10-31 13-58-55
@liza-mae liza-mae added the bug Fixes for quality problems that affect the customer experience label Oct 31, 2020
@liza-mae liza-mae changed the title Search does not work Global search does not work Oct 31, 2020
@liza-mae liza-mae added the REASSIGN from Team:Core UI Deprecated label for old Core UI team label Oct 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@mshustov
Copy link
Contributor

mshustov commented Nov 1, 2020

@liza-mae is it considered as a blocker for v7.10?

@liza-mae
Copy link
Contributor Author

liza-mae commented Nov 1, 2020 •
edited
Loading

@restrry I would consider it a blocker- let me get @LeeDr to weigh in also.

@liza-mae
Copy link
Contributor Author

liza-mae commented Nov 1, 2020

I did some additional testing and it looks like only the predefined apps drop-down does not work. If you enter another search term it does work, so maybe not blocker, thoughts?

@mshustov
Copy link
Contributor

mshustov commented Nov 2, 2020 •
edited
Loading

@pgayvallet would you mind taking a look, please? I'd expect GS falls back to the empty state #79123

@pgayvallet
Copy link
Contributor

pgayvallet commented Nov 2, 2020 •
edited
Loading

cc @elastic/kibana-core-ui @myasonik This is the same error I encountered a few weeks back (see discussion on the core-ui channel on slack on October 8th). Seems I'm not the only one encountering it.

@pgayvallet pgayvallet mentioned this issue Nov 2, 2020
Merged
@pgayvallet
Copy link
Contributor

Like last time, I couldn't really find a proper reproduction scenario. Not sure what the exact cause is creating this 'broken' state, but the consequence is an absence of selected items in the EUI component. Will be fixed by #82252.

@liza-mae
Copy link
Contributor Author

liza-mae commented Nov 2, 2020

Thanks for fixing @pgayvallet @restrry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker bug Fixes for quality problems that affect the customer experience REASSIGN from Team:Core UI Deprecated label for old Core UI team v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GS] Fix onChange error when submitting with no selected item(s) pgayvallet/kibana
4 participants
@pgayvallet @mshustov @elasticmachine @liza-mae