-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved empty state for nav search #79123
Conversation
@gchaps @alexfrancoeur it's been a while since this topic came up, but finally got all the pieces in place to improve the empty state for search! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
hah! nice illustration. Is this something we should standardize whenever there are no results across Kibana? While I love the black hole, my only concern it's not obvious enough as an illustration. I'm sure we'll get feedback if that's the case though. I mean hey, people love our 404's https://twitter.com/ali_tahir14/status/1306254454933594119?s=20 On the text, I'm not sure how well known "saved objects" are to end users, especially if you're not an admin. Would it be better to list some examples? "Try searching for applications, dashboards, visualizations and more" or something along those lines. |
I was curious about the familiarity of that term and what you proposed is much clearer, imo. |
+1 for the text Alex suggested, but with the serial comma: Try searching for applications, dashboards, visualizations, and more. |
💚 Build SucceededMetrics [docs]page load bundle size
History
To update your PR or re-run it, just comment with: |
On the topic of re-using illustrations, we don't currently have a central place where these are stored that I'm aware of. I brought this up, internally, at the outset of the work and will track that as a separate thing for us to define a pattern for. |
* Improved empty state for nav search * Updates tests to include required props * Update empty state text
Summary
The no results state for nav search left something to be desired, so this PR improves upon it by adding a fun illustration (courtesy of @JessSmithSup 🙇 ).
Before
After (dark mode)
After (light mode)
Note: During this process, we discovered that we were not providing a
noMatchesMessage
onEuiSelectableTemplateSitewide
. For now, we are displaying the same empty state message for both cases, but in the future (once we address #75040) we'll strongly consider providing different messages.Checklist
Delete any items that are not applicable to this PR.