Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved empty state for nav search #79123

Merged
merged 5 commits into from
Oct 2, 2020

Conversation

ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented Oct 1, 2020

Summary

The no results state for nav search left something to be desired, so this PR improves upon it by adding a fun illustration (courtesy of @JessSmithSup 🙇 ).

Before

Screen Shot 2020-09-30 at 9 54 37 AM

After (dark mode)

Screen Shot 2020-10-01 at 8 59 54 AM

After (light mode)

Screen Shot 2020-10-01 at 8 59 11 AM

Note: During this process, we discovered that we were not providing a noMatchesMessage on EuiSelectableTemplateSitewide. For now, we are displaying the same empty state message for both cases, but in the future (once we address #75040) we'll strongly consider providing different messages.

Checklist

Delete any items that are not applicable to this PR.

@ryankeairns ryankeairns added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Oct 1, 2020
@ryankeairns ryankeairns marked this pull request as ready for review October 1, 2020 20:35
@ryankeairns
Copy link
Contributor Author

@gchaps @alexfrancoeur it's been a while since this topic came up, but finally got all the pieces in place to improve the empty state for search!

Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@alexfrancoeur
Copy link

hah! nice illustration. Is this something we should standardize whenever there are no results across Kibana? While I love the black hole, my only concern it's not obvious enough as an illustration. I'm sure we'll get feedback if that's the case though. I mean hey, people love our 404's https://twitter.com/ali_tahir14/status/1306254454933594119?s=20

On the text, I'm not sure how well known "saved objects" are to end users, especially if you're not an admin. Would it be better to list some examples? "Try searching for applications, dashboards, visualizations and more" or something along those lines.

@ryankeairns
Copy link
Contributor Author

I was curious about the familiarity of that term and what you proposed is much clearer, imo.

@gchaps
Copy link
Contributor

gchaps commented Oct 1, 2020

+1 for the text Alex suggested, but with the serial comma:

Try searching for applications, dashboards, visualizations, and more.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id before after diff
globalSearchBar 28.0KB 28.7KB +780.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ryankeairns
Copy link
Contributor Author

On the topic of re-using illustrations, we don't currently have a central place where these are stored that I'm aware of. I brought this up, internally, at the outset of the work and will track that as a separate thing for us to define a pattern for.

@ryankeairns ryankeairns merged commit a7d9e2f into elastic:master Oct 2, 2020
ryankeairns added a commit to ryankeairns/kibana that referenced this pull request Oct 2, 2020
* Improved empty state for nav search

* Updates tests to include required props

* Update empty state text
ryankeairns added a commit that referenced this pull request Oct 2, 2020
* Improved empty state for nav search

* Updates tests to include required props

* Update empty state text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants