Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager]: The long policy name breaks the UI structure for the logs table under agent "Logs" tab. #89831

Closed
amolnater-qasource opened this issue Feb 1, 2021 · 7 comments · Fixed by #91776
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@amolnater-qasource
Copy link

amolnater-qasource commented Feb 1, 2021

Kibana version: Kibana: 7.11.0 BC-5 Cloud environment

Host OS and Browser version: Windows 10, All

Preconditions:

  1. 7.11.0 BC-5 Cloud environment should be available.
    Build Details:
    Artifact link used: https://staging.elastic.co/7.11.0-903dc0b6/downloads/beats/elastic-agent/elastic-agent-7.11.0-windows-x86_64.zip
    BUILD: 37827
    COMMIT: d801a7bb08e17368584d00fbd97a5d0006285b51
  1. Agent must be enrolled with long name policy(525 bytes).

Steps to reproduce:

  1. Login to Kibana cloud environment.
  2. Navigate to Fleet>Logs tab.
  3. Observe that UI structure is normal for logs table.
  4. Navigate to "Agent Details" page and again navigate to "Logs" tab.
  5. Observe that UI structure is broken for the logs table under "Logs" tab.

Expected Result:
The long policy name should not break the UI structure for the logs table under agent "Logs" tab.

Screenshots:
LongName

**What's Working **
On hard refreshing "Logs" page, logs table structure returns to normal size

Note:

@amolnater-qasource amolnater-qasource added the bug Fixes for quality problems that affect the customer experience label Feb 1, 2021
@amolnater-qasource amolnater-qasource added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Feb 1, 2021
@amolnater-qasource
Copy link
Author

@manishgupta-qasource Please review. Thanks

@manishgupta-qasource
Copy link

Reviewed & assigned to @EricDavisX & @jen-huang

jen-huang added a commit to jen-huang/kibana that referenced this issue Feb 17, 2021
@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jen-huang
Copy link
Contributor

jen-huang commented Feb 17, 2021

I have a fix up in #91776. The reason the height of the logs component differs on page reload vs switching between Agent details and Logs tab is because we let the logs take up the "rest of the page" (height-wise). On page reload, the long agent policy name takes a little bit longer to load, so a larger height is set on the logs before the agent policy name pushes everything down. When switching tabs, the agent policy name is already there so the available height is less.

The solution in the PR adds a minimum height to the logs component of 600px. So the expected behavior is that the logs component will be the greater between 600px or the height of the rest of the page depending on your browser size.

@amolnater-qasource
Copy link
Author

Hi @jen-huang
We have revalidated this issue on 7.12.0 Snapshot Kibana cloud environment and found this issue not fixed as we are not able to view logs table with long name policy on switching tabs from "Agent details" to "Logs".

Screenshot:
4

Build details:

Artifact link used: https://snapshots.elastic.co/7.12.0-7f1cfbda/downloads/beats/elastic-agent/elastic-agent-7.12.0-SNAPSHOT-windows-x86_64.zip
Build: 38790
Commit: 1fc8122

Please let us know if anything else is required.

Thanks
QAS

@jen-huang
Copy link
Contributor

jen-huang commented Feb 19, 2021

@amolnater-qasource Sorry, the PR is not merged yet so I don't expect it to be fixed in the BCs yet, just wanted to give some background on why this issue occurs. Please keep on eye on when the PR merges to retest (this issue will auto-close when it does).

jen-huang added a commit that referenced this issue Feb 19, 2021
* Fix #85521

* Set a minimum height for agent logs component #89831

* Truncate long integration names nicely #85404
jen-huang added a commit to jen-huang/kibana that referenced this issue Feb 19, 2021
* Fix elastic#85521

* Set a minimum height for agent logs component elastic#89831

* Truncate long integration names nicely elastic#85404
jen-huang added a commit to jen-huang/kibana that referenced this issue Feb 19, 2021
* Fix elastic#85521

* Set a minimum height for agent logs component elastic#89831

* Truncate long integration names nicely elastic#85404
jen-huang added a commit that referenced this issue Feb 19, 2021
* Fix #85521

* Set a minimum height for agent logs component #89831

* Truncate long integration names nicely #85404
jen-huang added a commit that referenced this issue Feb 19, 2021
* Fix #85521

* Set a minimum height for agent logs component #89831

* Truncate long integration names nicely #85404
@amolnater-qasource
Copy link
Author

Hi @jen-huang
We have revalidated this issue on 7.12.0 Snapshot Kibana cloud environment and found it fixed.

Screenshot:
2

Build details:

Build: 38956
Commit: 90fc153d85334ec153204ac9d3702b26a38099e4

Thanks
QAS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants