-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce core
bundle size
#95890
Comments
Pinging @elastic/kibana-core (Team:Core) |
Not sure we can gain much with async loading UI components in core, as we are just delegating to EUI which is already a shared dep. E.g
The
The rest of the UI component in
Only UI component here is kibana/src/core/public/overlays/flyout/flyout_service.tsx Lines 121 to 128 in 4584a8b
As
Same, UI comp is only a passthough to EUI kibana/src/core/public/overlays/modal/modal_service.tsx Lines 199 to 204 in 8126488
The toast list is currently rendered during kibana/src/core/public/notifications/toasts/toasts_service.tsx Lines 49 to 61 in 4584a8b
Changing to lazy load would force us to adapt the code to only render the component when a first toast is actually received. Also So I don't think we should do anything for
Opened a PR #96020 to try that one. I guess the gain will be negligible too, but waiting for CI. |
Parent issue #95853
Core bundle size is critical for performance because it's loaded on every page and delays all other plugin initialization affecting perceived UI performance.
There are still lots of options to improve Core bundle size, just a few ideas:
@kbn/std
tokbn-ui-shared-library
Move more Kibana packages to UI shared deps #95894@elastic/safer-lodash-set
tokbn-ui-shared-library
Move more Kibana packages to UI shared deps #95894node-libs-browser
from the build,util
usagekibana/src/core/public/fatal_errors/get_error_info.ts
Line 9 in e91d0d4
Sha256
that usesBuffer
and requires the polyfill (~40kB):kibana/src/core/public/utils/crypto/sha256.ts
Line 77 in 4681a80
css
built-in bycss-loader
We don't aim to abide by the 100KB limit set for plugins. The limit bundle size value for Core should be investigated as a part of this issue.
The text was updated successfully, but these errors were encountered: