Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy load the fatal error UI #96020

Closed

Conversation

pgayvallet
Copy link
Contributor

Summary

Part of #95890

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@pgayvallet pgayvallet mentioned this pull request Apr 1, 2021
10 tasks
@pgayvallet
Copy link
Contributor Author

Screenshot 2021-04-01 at 11 59 06

-3.2kb on main bundle, +4.4kb on async chunks.

@mshustov before I fix the unit tests, do you think it is worth it to merge that?

@mshustov
Copy link
Contributor

mshustov commented Apr 1, 2021

@pgayvallet not sure. Let's focus on something with more potential upside

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
core 226.8KB 231.2KB +4.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 373.0KB 369.8KB -3.2KB
Unknown metric groups

async chunk count

id before after diff
core 2 3 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet
Copy link
Contributor Author

Gain is not significant enough. Closing.

@pgayvallet pgayvallet closed this Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants