-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HeaderMenuPortal error when navigating between observability and APM #97140
Labels
bug
Fixes for quality problems that affect the customer experience
Team:Observability
Team label for Observability Team (for things that are handled across all of observability)
Theme: rac
label obsolete
v7.14.0
Comments
smith
added
bug
Fixes for quality problems that affect the customer experience
Team:Observability
Team label for Observability Team (for things that are handled across all of observability)
v7.14.0
Theme: rac
label obsolete
labels
Apr 14, 2021
smith
added a commit
to smith/kibana
that referenced
this issue
May 28, 2021
Call `setHeaderActionMenu(undefined)` when the HeaderMenuPortal is unmounted. Found this line in the docs: > Calling the handler with `undefined` will unmount the current mount point. Which we weren't doing before. Previous behavior: * Go to /app/observability/alerts * Click the "View in app" button for an APM alert * Click back * Click the "View in app" button for an APM alert * Get a weird toast error message and the header menu is gone forever Now: * Go to /app/observability/alerts * Click the "View in app" button for an APM alert * Click back * Click the "View in app" button for an APM alert * Get a working header menu Fixes elastic#97140
smith
added a commit
that referenced
this issue
May 28, 2021
Call `setHeaderActionMenu(undefined)` when the HeaderMenuPortal is unmounted. Found this line in the docs: > Calling the handler with `undefined` will unmount the current mount point. Which we weren't doing before. Previous behavior: * Go to /app/observability/alerts * Click the "View in app" button for an APM alert * Click back * Click the "View in app" button for an APM alert * Get a weird toast error message and the header menu is gone forever Now: * Go to /app/observability/alerts * Click the "View in app" button for an APM alert * Click back * Click the "View in app" button for an APM alert * Get a working header menu Fixes #97140
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
May 28, 2021
Call `setHeaderActionMenu(undefined)` when the HeaderMenuPortal is unmounted. Found this line in the docs: > Calling the handler with `undefined` will unmount the current mount point. Which we weren't doing before. Previous behavior: * Go to /app/observability/alerts * Click the "View in app" button for an APM alert * Click back * Click the "View in app" button for an APM alert * Get a weird toast error message and the header menu is gone forever Now: * Go to /app/observability/alerts * Click the "View in app" button for an APM alert * Click back * Click the "View in app" button for an APM alert * Get a working header menu Fixes elastic#97140
kibanamachine
added a commit
that referenced
this issue
May 28, 2021
Call `setHeaderActionMenu(undefined)` when the HeaderMenuPortal is unmounted. Found this line in the docs: > Calling the handler with `undefined` will unmount the current mount point. Which we weren't doing before. Previous behavior: * Go to /app/observability/alerts * Click the "View in app" button for an APM alert * Click back * Click the "View in app" button for an APM alert * Get a weird toast error message and the header menu is gone forever Now: * Go to /app/observability/alerts * Click the "View in app" button for an APM alert * Click back * Click the "View in app" button for an APM alert * Get a working header menu Fixes #97140 Co-authored-by: Nathan L Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Team:Observability
Team label for Observability Team (for things that are handled across all of observability)
Theme: rac
label obsolete
v7.14.0
On the alerts table in Observability there are links to the APM app for APM-related alerts in the table.
When you have the popover for an alert open then click the link on the table behind the popover, you get the following errors:
and so on.
This probably has something to do with the mounting/unmounting of portals and reverse portals.
The text was updated successfully, but these errors were encountered: