-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[index patterns] index pattern create modal #101853
[index patterns] index pattern create modal #101853
Conversation
…om:mattkime/kibana into rollup_creation_code_to_index_pattern_mgmt
…ttern_mgmt' into index_pattern_create_modal
@mattkime does this also include an inline editing experience or just create? There are a variety of use cases in which (in context) one might want to modify a field in an index pattern. |
@alexfrancoeur This is just create. We also have the index pattern field editor but it assumes the app provides the field list. If something new is needed lets talk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments.
...or/public/components/empty_prompts/empty_index_pattern_prompt/empty_index_pattern_prompt.tsx
Outdated
Show resolved
Hide resolved
src/plugins/index_pattern_editor/public/components/form_fields/timestamp_field.tsx
Outdated
Show resolved
Hide resolved
src/plugins/index_pattern_editor/public/components/form_fields/timestamp_field.tsx
Outdated
Show resolved
Hide resolved
src/plugins/index_pattern_editor/public/components/i18n_texts.ts
Outdated
Show resolved
Hide resolved
<span> | ||
<FormattedMessage | ||
id="indexPatternEditor.status.notMatchLabel.notMatchDetail" | ||
defaultMessage="The index pattern you've entered doesn't match any indices, data streams, or index aliases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defaultMessage="The index pattern you've entered doesn't match any indices, data streams, or index aliases. | |
defaultMessage="The index pattern you entered doesn't match any data streams, indices, or aliases. |
id="indexPatternManagement.createIndexPattern.step.status.noSystemIndicesWithPromptLabel" | ||
defaultMessage="No Elasticsearch indices match your pattern. To view the matching system indices, toggle the switch above." | ||
id="indexPatternEditor.status.noSystemIndicesWithPromptLabel" | ||
defaultMessage="No Elasticsearch indices match your pattern." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is indices correct here? Or is it data streams, indices, or aliases?
src/plugins/index_pattern_editor/public/components/form_fields/title_field.tsx
Outdated
Show resolved
Hide resolved
/> | ||
</span> | ||
); | ||
} else { | ||
statusMessage = ( | ||
<span> | ||
<FormattedMessage | ||
id="indexPatternManagement.createIndexPattern.step.status.noSystemIndicesLabel" | ||
id="indexPatternEditor.status.noSystemIndicesLabel" | ||
defaultMessage="No Elasticsearch indices match your pattern." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above.
id="indexPatternManagement.createIndexPattern.step.status.partialMatchLabel.partialMatchDetail" | ||
defaultMessage="Your index pattern doesn't match any indices, but you have {strongIndices} which | ||
id="indexPatternEditor.status.partialMatchLabel.partialMatchDetail" | ||
defaultMessage="Your index pattern doesn't match any sources, but you have {strongIndices} which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does something like this work?
Your index pattern doesn't match any data streams, indices, or aliases, but some sources are similar.
<FormattedMessage | ||
id="indexPatternEditor.status.notMatchLabel.notMatchDetail" | ||
defaultMessage="The index pattern you've entered doesn't match any indices, data streams, or index aliases. | ||
You can match {strongIndices}, below." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if this is a data stream or alias? Available matches are below?
…ts/empty_index_pattern_prompt/empty_index_pattern_prompt.tsx Co-authored-by: gchaps <[email protected]>
…/timestamp_field.tsx Co-authored-by: gchaps <[email protected]>
…/timestamp_field.tsx Co-authored-by: gchaps <[email protected]>
Co-authored-by: gchaps <[email protected]>
…/title_field.tsx Co-authored-by: gchaps <[email protected]>
…na into index_pattern_create_modal
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsAPI count
API count missing comments
async chunk count
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
index pattern creation flyout
index pattern creation flyout
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (392 commits) update linting doc (elastic#105748) [APM] Various improvements from elastic#104851 (elastic#107726) Update dependency @elastic/charts to v33.2.0 (master) (elastic#107842) Fix default route link on kibana homepage (elastic#107809) [APM] Invalidate trackPageview on route change (elastic#107741) Service map backend links (elastic#107317) [index patterns] index pattern create modal (elastic#101853) [RAC] integrating rbac search strategy with alert table (elastic#107242) [Security Solution] Siem signals -> alerts as data field and index aliases (elastic#106049) [Metrics UI] Add checkbox to optionally drop partial buckets (elastic#107676) [Metrics UI] Fix metric threshold preview regression (elastic#107674) Disable Product check in @elastic/elasticsearch-js (elastic#107642) [App Search] Migrate Crawler Status Indicator, Crawler Status Banner, and Crawl Request polling (elastic#107603) [Security Solution, Lists] Replace legacy imports from 'elasticsearch' package (elastic#107226) [maps] asset tracking tutorial (elastic#104552) [scripts/build_ts_refs] when using `--clean` initialize caches (elastic#107777) Upgrade EUI to v36.1.0 (elastic#107231) [RAC] [TGrid] Implements cell actions in the TGrid (elastic#107771) Realign cypress/ccs_integration with cypress/integration (elastic#107743) Allow optional OSS to X-Pack dependencies (elastic#107432) ... # Conflicts: # x-pack/examples/reporting_example/public/application.tsx # x-pack/examples/reporting_example/public/components/app.tsx # x-pack/plugins/canvas/public/services/legacy/stubs/reporting.ts # x-pack/plugins/reporting/common/types.ts # x-pack/plugins/reporting/public/lib/reporting_api_client/context.tsx # x-pack/plugins/reporting/public/management/mount_management_section.tsx # x-pack/plugins/reporting/public/management/report_listing.test.tsx # x-pack/plugins/reporting/public/plugin.ts # x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx # x-pack/plugins/reporting/server/export_types/printable_pdf/execute_job/index.ts
* [index patterns] index pattern create modal (#101853) index pattern creation flyout * update docs * update limits * Update limits.yml Co-authored-by: Kibana Machine <[email protected]>
Summary
Index pattern creation modal - create index patterns from any kibana app. Initial implementation in index pattern management.
Closes #84725
To test
Test with index w/o a time field -
create an index without a time field -
Test with a rollup index
Checklist
Delete any items that are not applicable to this PR.