Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip the reporting screenshots.ts by fixing unable to update UI settings error. #103184

Merged
merged 5 commits into from
Jun 28, 2021
Merged

Unskip the reporting screenshots.ts by fixing unable to update UI settings error. #103184

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5247697
fixing unskipped test with uiSettings update
bhavyarm Jun 23, 2021
7afba00
Merge branch 'master' into unskipReportingKbnArchiver
bhavyarm Jun 28, 2021
bb3025c
Merge branch 'master' into unskipReportingKbnArchiver
bhavyarm Jun 28, 2021
c69ee61
moving ui settings update into test for non legacy table
bhavyarm Jun 28, 2021
085cf24
Merge branch 'master' into unskipReportingKbnArchiver
kibanamachine Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions x-pack/test/functional/apps/dashboard/reporting/screenshots.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,12 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const kibanaServer = getService('kibanaServer');
const ecommerceSOPath = 'x-pack/test/functional/fixtures/kbn_archiver/reporting/ecommerce.json';

// https://github.com/elastic/kibana/issues/102911
describe.skip('Dashboard Reporting Screenshots', () => {
describe('Dashboard Reporting Screenshots', () => {
before('initialize tests', async () => {
await kibanaServer.uiSettings.replace({
defaultIndex: '5193f870-d861-11e9-a311-0fa548c5f953',
});
await kibanaServer.uiSettings.update({ 'doc_table:legacy': false });
bhavyarm marked this conversation as resolved.
Show resolved Hide resolved
await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/reporting/ecommerce');
await kibanaServer.importExport.load(ecommerceSOPath);
await browser.setWindowSize(1600, 850);
Expand Down Expand Up @@ -215,7 +218,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
});

it('downloads a PDF file with saved search given EuiDataGrid enabled', async function () {
await kibanaServer.uiSettings.replace({ 'doc_table:legacy': false });
this.timeout(300000);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.loadSavedDashboard('Ecom Dashboard');
Expand Down