-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] deprecate 'map.regionmap' kibana config and 'Configured GeoJSON' source #103373
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
+1 on removing the add-layer-card altogether. cc @kmartastic - this PR removes the ability for users to create new layers from a json-file configured in the kibana.yml (existing maps continue to work though).
@@ -117,41 +101,3 @@ export function getGlyphUrl(): string { | |||
export function isRetina(): boolean { | |||
return window.devicePixelRatio === 2; | |||
} | |||
|
|||
export async function fetchGeoJson( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for moving. This logic was pushed into ems-client, so there was no re-use anymore between kibana_regionmap_source
and ems_layer_source
icon: isDeprecated ? ( | ||
<EuiIcon type="alert" color="danger" /> | ||
) : ( | ||
this.getCurrentStyle().getIcon() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a nice touch.
…N' source (elastic#103373) * [Maps] deprecate 'map.regionmap' kibana config and 'Configured GeoJSON' source * clean up message * revert change to KibanaRegionmapSource.getGeoJsonWithMeta * tslint * doc updates * clean up Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…N' source (#103373) (#103576) * [Maps] deprecate 'map.regionmap' kibana config and 'Configured GeoJSON' source * clean up message * revert change to KibanaRegionmapSource.getGeoJsonWithMeta * tslint * doc updates * clean up Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Nathan Reese <[email protected]>
Part of #97532
This PR:
To test:
map.regionmap