Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fleet settings for 7.14 #103380

Merged
merged 4 commits into from
Jul 26, 2021
Merged

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Jun 25, 2021

Summary

Closes elastic/observability-docs#758.

Updates Fleet settings for 7.14.

Checklist

Delete any items that are not applicable to this PR.

@dedemorton dedemorton added Feature:Fleet Fleet team's agent central management project docs v7.14.0 labels Jun 25, 2021
@dedemorton dedemorton self-assigned this Jun 25, 2021
@dedemorton dedemorton force-pushed the obs-docs-issue#758 branch from f585ea8 to a99f2dc Compare June 28, 2021 22:57
@dedemorton dedemorton changed the title [WIP] Update Fleet settings for 7.14 Update Fleet settings for 7.14 Jun 28, 2021
@dedemorton
Copy link
Contributor Author

@jen-huang As a first pass, let's make sure the Kibana docs are complete.

I agree that the disconnect between the Fleet User Guide and Kibana Guide is potentially confusing for users. But I suspect the @elastic/kibana-docs team wants to have all the kibana.yml settings in the same place.

The settings in the Fleet User Guide are exposed in the UI, so I think they need to be described in the Fleet User Guide. If we keep both topics, we should make sure there are links between the topics.

One thing I wasn't quite sure about was precedence. It's possible to set options in kibana.yml, in the elasticsearch output of the agent config, and from the command line. Which settings take precedence?

@Zacqary added you as a reviewer. I have a few questions about some of the descriptions you provided.

@dedemorton dedemorton requested review from Zacqary and jen-huang June 28, 2021 23:09
@dedemorton dedemorton marked this pull request as ready for review June 28, 2021 23:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Feature:Fleet)

@dedemorton dedemorton added the release_note:skip Skip the PR/issue when compiling release notes label Jun 28, 2021
@dedemorton dedemorton requested a review from a team June 28, 2021 23:10
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dedemorton
Copy link
Contributor Author

bump. Thanks to Gail for her review, but I still need input from someone on the dev team.

@kpollich
Copy link
Member

cc @jen-huang - I think you are probably best suited to answer some of @dedemorton's questions and review these docs.

docs/settings/fleet-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/fleet-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/fleet-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/fleet-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/fleet-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/fleet-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/fleet-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/fleet-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/fleet-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/fleet-settings.asciidoc Outdated Show resolved Hide resolved
@jen-huang
Copy link
Contributor

One thing I wasn't quite sure about was precedence. It's possible to set options in kibana.yml, in the elasticsearch output of the agent config, and from the command line. Which settings take precedence?

I think this varies depending on the setting, and not all of these setting are available in all three places.

For xpack.fleet.agents.fleet_server.* and xpack.fleet.agents.elasticsearch.* settings, command line takes precedence, followed by changes in the Fleet UI, and lastly from kibana.yml. (Actually kibana.yml values are ignored once we've populated Fleet settings from them: #105400 (comment))

@dedemorton dedemorton merged commit 4f5e2a6 into elastic:master Jul 26, 2021
@dedemorton dedemorton deleted the obs-docs-issue#758 branch July 26, 2021 16:11
dedemorton added a commit to dedemorton/kibana that referenced this pull request Jul 26, 2021
* Update Fleet settings for 7.14

* Apply jen-huang's suggestions from code review

Co-authored-by: Jen Huang <[email protected]>

* Add fixes from the review

Co-authored-by: Jen Huang <[email protected]>
dedemorton added a commit to dedemorton/kibana that referenced this pull request Jul 26, 2021
* Update Fleet settings for 7.14

* Apply jen-huang's suggestions from code review

Co-authored-by: Jen Huang <[email protected]>

* Add fixes from the review

Co-authored-by: Jen Huang <[email protected]>
dedemorton added a commit that referenced this pull request Jul 26, 2021
* Update Fleet settings for 7.14

* Apply jen-huang's suggestions from code review

Co-authored-by: Jen Huang <[email protected]>

* Add fixes from the review

Co-authored-by: Jen Huang <[email protected]>

Co-authored-by: Jen Huang <[email protected]>
dedemorton added a commit that referenced this pull request Jul 26, 2021
* Update Fleet settings for 7.14

* Apply jen-huang's suggestions from code review

Co-authored-by: Jen Huang <[email protected]>

* Add fixes from the review

Co-authored-by: Jen Huang <[email protected]>

Co-authored-by: Jen Huang <[email protected]>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
* Update Fleet settings for 7.14

* Apply jen-huang's suggestions from code review

Co-authored-by: Jen Huang <[email protected]>

* Add fixes from the review

Co-authored-by: Jen Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Feature:Fleet Fleet team's agent central management project release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update/consolidate Fleet kibana.yml settings
6 participants