chore(NA): enable bazel exports directories only at yarn_install #104180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
reviewed
Jul 1, 2021
There was a problem hiding this comment.
info [bazel] build-runfiles error: CreateSymbolicLinkW failed:
info [bazel] Bazel needs to create symlink for building runfiles tree.
info [bazel] Creating symlink on Windows requires either of the following:
info [bazel] 1. Program is running with elevated privileges (Admin rights).
info [bazel] 2. The system version is Windows 10 Creators Update (1703) or later and developer mode is enabled.
info [bazel]
info [bazel] manifest file name: bazel-out/host/bin/external/npm/@bazel/typescript/bin/ts_project_options_validator.bat.runfiles_manifest
info [bazel] runfiles base directory: bazel-out/host/bin/external/npm/@bazel/typescript/bin/ts_project_options_validator.bat.runfiles
info [bazel] Target //packages:build failed to build
info [bazel] Use --verbose_failures to see the command lines of failed build steps.
info [bazel] ERROR: C:/users/jon/kibana/packages/kbn-ace/BUILD.bazel:72:8 Assembling npm package packages/kbn-ace/npm_module failed: build-runfiles.exe failed: error executing command
info [bazel] cd C:\users\jon\_bazel_jon\oha3m66j\execroot\kibana
info [bazel] SET PATH=C:\Program Files\Git\usr\bin;C:\Program Files\Git\bin;C:\Windows;C:\Windows\System32;C:\Windows\System32\WindowsPowerShell\v1.0
info [bazel] C:/users/jon/_bazel_jon/install/2892b90e19bb7ffd8c1021167002c944/build-runfiles.exe bazel-out/host/bin/external/npm/@bazel/typescript/bin/ts_project_options_validator.bat.runfiles_manifest bazel-out/host/bin/external/npm/@bazel/typescript/bin/ts_project_options_validator.bat.runfiles: Process exited with status 1: Process exited with status 1
I'll enable developer mode and report back.
jbudz
approved these changes
Jul 1, 2021
|
@jbudz we already require it here https://www.elastic.co/guide/en/kibana/master/development-getting-started.html#developing-on-windows @tylersmalley could we proceed here? |
|
@mistic, yeah it's a big win and already in the docs. Glad to see they got the feature in! |
|
@elasticmachine merge upstream |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 1, 2021
… performance (elastic#104180) Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
that referenced
this pull request
Jul 2, 2021
… performance (#104180) (#104234) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Tiago Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step forward on #69706
That PR enables a feature available in the last rules node js version called
exports-directories-only. At the yarn install phase bazel generates build files for each node module. Previously it was considering each file as part of the content which sometimes generates problems at bootstrap (expected files are not there) and also includes a performance penalty. With the new feature on it only considers each node module as tree artifact no matter what files is inside of it. I've registered a~40%performance improvement on a raw, clean and zero cacheyarn kbn bootstrap(that can be simulated with theyarn kbn resetcommand).