Upgrade from Node.js v14.17.2 to v14.17.3 #104417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
added
v8.0.0
release_note:skip
jbudz
approved these changes
Jul 6, 2021
|
Apparently Docker Hub is still not even ready with the image for last weeks upgrade. The reason for the test failures is that the latest 14.x image on Docker Hub is v14.17.1 😳 |
|
@watson merging now (minus Dockerfile changes) or waiting for a hub update both LGTM. Whichever's more convenient for you. |
|
14.17.2 is now on Docker hub, still waiting for 14.17.3. It should be very close though. Just waiting for nodejs/docker-node#1521 to make its way there |
|
Docker hub is now up to date - restarting build... |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @watson |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 8, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 8, 2021
kibanamachine
added a commit
that referenced
this pull request
Jul 8, 2021
Co-authored-by: Thomas Watson <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 8, 2021
Co-authored-by: Thomas Watson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually just wanted to get
.ci/Dockerfileup-to-date with the Node.js upgrade from last week (#104148), however, yesterday a new patch for Node.js 14 was released which fixes an issue with the Windows installer. So in the interest of Kibana developers running Windows, I thought I'd better upgrade to that version.Other than the fix for the Windows installer, nothing has changed compared to the previous version.
Node.js 14.17.3 changelog: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#14.17.3
Source for SHA256 hashes: https://nodejs.org/dist/v14.17.3/SHASUMS256.txt.asc