Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix error handling in job search bar #104759

Merged
merged 1 commit into from
Jul 8, 2021
Merged

[ML] Fix error handling in job search bar #104759

merged 1 commit into from
Jul 8, 2021

Conversation

jgowdyelastic
Copy link
Member

Query parsing errors thrown from the EuiSearchBar component were being lost due to a typo in the code introduced when it was converted to typescript in #83149

Errors are now correctly reported below the search bar.
image

@jgowdyelastic jgowdyelastic requested a review from a team as a code owner July 7, 2021 20:07
@jgowdyelastic jgowdyelastic mentioned this pull request Jul 7, 2021
Closed
@jgowdyelastic jgowdyelastic self-assigned this Jul 7, 2021
@jgowdyelastic jgowdyelastic added :ml auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection release_note:fix review v7.14.0 v7.15.0 v8.0.0 labels Jul 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +5.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

peteharverson
peteharverson approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@jgowdyelastic jgowdyelastic merged commit d4ecc01 into elastic:master Jul 8, 2021
@kibanamachine kibanamachine mentioned this pull request Jul 8, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2021
@jgowdyelastic @kibanamachine
[ML] Fix error handling in job search bar (elastic#104759)
311905c
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2021
@jgowdyelastic @kibanamachine
[ML] Fix error handling in job search bar (elastic#104759)
e8f35ba
@kibanamachine kibanamachine mentioned this pull request Jul 8, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

@jgowdyelastic jgowdyelastic deleted the fix-error-handling-in-job-search-bar branch July 8, 2021 16:53
kibanamachine added a commit that referenced this pull request Jul 8, 2021
@kibanamachine @jgowdyelastic
[ML] Fix error handling in job search bar (#104759) (#104922)
27638c8 
Co-authored-by: James Gowdy <[email protected]>
kibanamachine added a commit that referenced this pull request Jul 8, 2021
@kibanamachine @jgowdyelastic
[ML] Fix error handling in job search bar (#104759) (#104921)
24387e7 
Co-authored-by: James Gowdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@jgowdyelastic jgowdyelastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml release_note:fix review v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @kibanamachine @alvarezmelissa87 @peteharverson