-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Experiment: split Canvas Expression Definitions from async Expression logic #104990
Closed
clintandrewhall
wants to merge
1
commit into
elastic:main
from
clintandrewhall:canvas/async-fn-bodies
Closed
[RFC] Experiment: split Canvas Expression Definitions from async Expression logic #104990
clintandrewhall
wants to merge
1
commit into
elastic:main
from
clintandrewhall:canvas/async-fn-bodies
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintandrewhall
added
WIP
Work in progress
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
loe:medium
Medium Level of Effort
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
Feature:Canvas
labels
Jul 8, 2021
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / general / task-queue-process-11 / X-Pack Endpoint Functional Tests.x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list·ts.endpoint endpoint list when initially navigating to page "before all" hook for "finds no data in list and prompts onboarding to add policy"Standard Out
Stack Trace
Kibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/status_page/index·ts.status page "before each" hook for "should show the build hash and number"Standard Out
Stack Trace
Kibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_save·ts.dashboard app using legacy data dashboard save "before all" hook for "warns on duplicate name for new dashboard"Standard Out
Stack Trace
and 36 more failures, only showing the first 3. Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
References to deprecated APIs
To update your PR or re-run it, just comment with: |
This was referenced Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Canvas
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
loe:medium
Medium Level of Effort
release_note:skip
Skip the PR/issue when compiling release notes
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
v8.0.0
WIP
Work in progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #104264
I took six browser functions and:
Side-effects:
Before 23.5k
After 36.9k