chore(NA): moving @elastic/datemath to babel transpiler #106860

mistic · 2021-07-27T14:52:21Z

One step forward on #69706

That PR moves the @elastic/datemath from using tsc compiler to babel transpiler to produce the js outputs.

elasticmachine · 2021-07-27T14:52:23Z

Pinging @elastic/kibana-operations (Team:Operations)

packages/elastic-datemath/BUILD.bazel

jbudz

Windows LGTM

.gitignore

src/dev/bazel/jsts_transpiler.bzl

…-datemath-with-babel

tsullivan

code changes in app-services that switch from using tsc to using babel as the transpiler looks good to me.

kibanamachine · 2021-07-27T20:44:33Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`actions`	-	117	+117
`advancedSettings`	-	22	+22
`alerting`	-	234	+234
`apm`	-	39	+39
`apmOss`	-	4	+4
`banners`	-	9	+9
`bfetch`	-	62	+62
`canvas`	-	5	+5
`cases`	-	407	+407
`charts`	-	159	+159
`cloud`	-	21	+21
`core`	-	1081	+1081
`dashboard`	-	137	+137
`dashboardEnhanced`	-	50	+50
`dashboardMode`	-	11	+11
`data`	-	3162	+3162
`dataEnhanced`	-	16	+16
`dataVisualizer`	-	104	+104
`devTools`	-	8	+8
`discover`	-	55	+55
`discoverEnhanced`	-	37	+37
`embeddable`	-	384	+384
`embeddableEnhanced`	-	14	+14
`encryptedSavedObjects`	-	28	+28
`enterpriseSearch`	-	2	+2
`esUiShared`	-	90	+90
`eventLog`	-	70	+70
`expressionError`	-	12	+12
`expressionImage`	-	4	+4
`expressionMetric`	-	4	+4
`expressionRepeatImage`	-	28	+28
`expressionRevealImage`	-	4	+4
`expressions`	-	1569	+1569
`expressionShape`	-	90	+90
`features`	-	97	+97
`fileUpload`	-	128	+128
`fleet`	-	1033	+1033
`globalSearch`	-	14	+14
`home`	-	70	+70
`indexLifecycleManagement`	-	4	+4
`indexManagement`	-	157	+157
`indexPatternFieldEditor`	-	29	+29
`infra`	-	22	+22
`inspector`	-	78	+78
`kibanaLegacy`	-	62	+62
`kibanaReact`	-	230	+230
`kibanaUtils`	-	359	+359
`lens`	-	191	+191
`licenseApiGuard`	-	8	+8
`licenseManagement`	-	3	+3
`licensing`	-	42	+42
`lists`	-	143	+143
`management`	-	40	+40
`maps`	-	203	+203
`mapsEms`	-	75	+75
`metricsEntities`	-	6	+6
`ml`	-	274	+274
`monitoring`	-	10	+10
`navigation`	-	31	+31
`newsfeed`	-	17	+17
`observability`	-	219	+219
`osquery`	-	11	+11
`presentationUtil`	-	149	+149
`remoteClusters`	-	4	+4
`reporting`	-	132	+132
`rollup`	-	20	+20
`ruleRegistry`	-	60	+60
`runtimeFields`	-	19	+19
`savedObjects`	-	199	+199
`savedObjectsManagement`	-	85	+85
`savedObjectsTagging`	-	50	+50
`savedObjectsTaggingOss`	-	50	+50
`screenshotMode`	-	17	+17
`security`	-	51	+51
`securityOss`	-	9	+9
`securitySolution`	-	1245	+1245
`share`	-	83	+83
`snapshotRestore`	-	22	+22
`spacesOss`	-	5	+5
`stackAlerts`	-	4	+4
`taskManager`	-	25	+25
`telemetryCollectionManager`	-	29	+29
`telemetryCollectionXpack`	-	1	+1
`telemetryManagementSection`	-	13	+13
`timelines`	-	763	+763
`triggersActionsUi`	-	228	+228
`uiActions`	-	88	+88
`uiActionsEnhanced`	-	147	+147
`urlForwarding`	-	15	+15
`usageCollection`	-	16	+16
`visTypeTimeseries`	-	10	+10
`visualizations`	-	229	+229
total			+15363

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
`bfetch`	-	1	+1
`charts`	-	2	+2
`core`	-	148	+148
`dashboard`	-	1	+1
`data`	-	98	+98
`dataVisualizer`	-	3	+3
`embeddable`	-	4	+4
`esUiShared`	-	4	+4
`expressions`	-	58	+58
`fileUpload`	-	4	+4
`fleet`	-	15	+15
`indexManagement`	-	12	+12
`indexPatternFieldEditor`	-	1	+1
`inspector`	-	6	+6
`kibanaLegacy`	-	3	+3
`kibanaReact`	-	5	+5
`kibanaUtils`	-	3	+3
`maps`	-	2	+2
`mapsEms`	-	1	+1
`ml`	-	10	+10
`presentationUtil`	-	3	+3
`reporting`	-	1	+1
`savedObjects`	-	3	+3
`savedObjectsTaggingOss`	-	3	+3
`securitySolution`	-	8	+8
`share`	-	1	+1
`snapshotRestore`	-	1	+1
`timelines`	-	6	+6
`triggersActionsUi`	-	1	+1
`uiActionsEnhanced`	-	2	+2
`visTypeTimeseries`	-	1	+1
`visualizations`	-	13	+13
total			+424

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	4.2MB	4.2MB	+35.0B
`canvas`	1.5MB	1.5MB	+52.0B
`data`	164.7KB	164.8KB	+60.0B
`dataVisualizer`	1.1MB	1.1MB	+42.0B
`discover`	495.8KB	495.9KB	+80.0B
`infra`	1.7MB	1.7MB	+39.0B
`lens`	1.6MB	1.6MB	+42.0B
`lists`	276.1KB	276.1KB	+20.0B
`ml`	6.0MB	6.0MB	+23.0B
`observability`	490.7KB	490.8KB	+7.0B
`securitySolution`	6.4MB	6.4MB	+66.0B
`uptime`	949.6KB	949.6KB	+55.0B
`visDefaultEditor`	224.5KB	224.6KB	+55.0B
`visTypeTimeseries`	1003.4KB	1003.5KB	+120.0B
`visTypeVega`	2.4MB	2.4MB	+60.0B
`visTypeVislib`	564.4KB	564.4KB	+54.0B
`watcher`	839.5KB	839.5KB	+60.0B
total			+870.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`actions`	-	7	+7
`advancedSettings`	-	1	+1
`alerting`	-	16	+16
`apm`	-	30	+30
`bfetch`	-	2	+2
`canvas`	-	3	+3
`cases`	-	14	+14
`charts`	-	1	+1
`core`	-	31	+31
`dashboard`	-	9	+9
`data`	-	64	+64
`dataEnhanced`	-	2	+2
`devTools`	-	2	+2
`discover`	-	6	+6
`discoverEnhanced`	-	2	+2
`embeddable`	-	3	+3
`encryptedSavedObjects`	-	3	+3
`esUiShared`	-	1	+1
`eventLog`	-	4	+4
`expressionError`	-	2	+2
`expressionImage`	-	1	+1
`expressionMetric`	-	1	+1
`expressionRevealImage`	-	1	+1
`expressions`	-	5	+5
`features`	-	2	+2
`fileUpload`	-	1	+1
`fleet`	-	8	+8
`globalSearch`	-	5	+5
`home`	-	5	+5
`indexManagement`	-	3	+3
`indexPatternFieldEditor`	-	4	+4
`infra`	-	3	+3
`inspector`	-	4	+4
`kibanaLegacy`	-	1	+1
`kibanaReact`	-	4	+4
`kibanaUtils`	-	8	+8
`lens`	-	23	+23
`licensing`	-	8	+8
`lists`	-	38	+38
`management`	-	5	+5
`maps`	-	11	+11
`metricsEntities`	-	1	+1
`ml`	-	33	+33
`monitoring`	-	2	+2
`navigation`	-	2	+2
`observability`	-	10	+10
`presentationUtil`	-	5	+5
`reporting`	-	14	+14
`ruleRegistry`	-	9	+9
`runtimeFields`	-	2	+2
`savedObjects`	-	5	+5
`screenshotMode`	-	1	+1
`security`	-	6	+6
`securityOss`	-	3	+3
`securitySolution`	-	28	+28
`share`	-	8	+8
`snapshotRestore`	-	1	+1
`taskManager`	-	8	+8
`telemetryCollectionManager`	-	4	+4
`timelines`	-	25	+25
`triggersActionsUi`	-	19	+19
`uiActions`	-	11	+11
`uiActionsEnhanced`	-	10	+10
`usageCollection`	-	2	+2
`visTypeTimeseries`	-	3	+3
`visualizations`	-	12	+12
total			+568

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`canvas`	25.3KB	25.2KB	-65.0B
`data`	837.7KB	837.9KB	+181.0B
`infra`	145.3KB	145.3KB	+35.0B
`kbnUiSharedDeps-elastic`	2.6MB	2.6MB	-20.0B
`ml`	64.4KB	64.5KB	+35.0B
`observability`	59.6KB	59.7KB	+35.0B
`uiActionsEnhanced`	231.5KB	231.5KB	+55.0B
`visTypeVislib`	32.5KB	32.4KB	-65.0B
total			+191.0B

Unknown metric groups

API count

id	before	after	diff
`actions`	-	117	+117
`advancedSettings`	-	23	+23
`alerting`	-	242	+242
`apm`	-	39	+39
`apmOss`	-	4	+4
`banners`	-	9	+9
`bfetch`	-	73	+73
`canvas`	-	6	+6
`cases`	-	445	+445
`charts`	-	190	+190
`cloud`	-	21	+21
`core`	-	2360	+2360
`dashboard`	-	160	+160
`dashboardEnhanced`	-	51	+51
`dashboardMode`	-	11	+11
`data`	-	3716	+3716
`dataEnhanced`	-	16	+16
`dataVisualizer`	-	104	+104
`devTools`	-	10	+10
`discover`	-	81	+81
`discoverEnhanced`	-	39	+39
`embeddable`	-	456	+456
`embeddableEnhanced`	-	14	+14
`encryptedSavedObjects`	-	30	+30
`enterpriseSearch`	-	2	+2
`esUiShared`	-	92	+92
`eventLog`	-	70	+70
`expressionError`	-	12	+12
`expressionImage`	-	4	+4
`expressionMetric`	-	4	+4
`expressionRepeatImage`	-	28	+28
`expressionRevealImage`	-	4	+4
`expressions`	-	2003	+2003
`expressionShape`	-	90	+90
`features`	-	215	+215
`fileUpload`	-	128	+128
`fleet`	-	1128	+1128
`globalSearch`	-	68	+68
`home`	-	94	+94
`indexLifecycleManagement`	-	4	+4
`indexManagement`	-	162	+162
`indexPatternFieldEditor`	-	31	+31
`infra`	-	25	+25
`inspector`	-	101	+101
`kibanaLegacy`	-	66	+66
`kibanaReact`	-	260	+260
`kibanaUtils`	-	551	+551
`lens`	-	207	+207
`licenseApiGuard`	-	8	+8
`licenseManagement`	-	3	+3
`licensing`	-	117	+117
`lists`	-	150	+150
`management`	-	40	+40
`maps`	-	204	+204
`mapsEms`	-	75	+75
`metricsEntities`	-	9	+9
`ml`	-	278	+278
`monitoring`	-	10	+10
`navigation`	-	31	+31
`newsfeed`	-	17	+17
`observability`	-	219	+219
`osquery`	-	11	+11
`presentationUtil`	-	176	+176
`remoteClusters`	-	4	+4
`reporting`	-	133	+133
`rollup`	-	20	+20
`ruleRegistry`	-	60	+60
`runtimeFields`	-	24	+24
`savedObjects`	-	213	+213
`savedObjectsManagement`	-	96	+96
`savedObjectsTagging`	-	54	+54
`savedObjectsTaggingOss`	-	89	+89
`screenshotMode`	-	22	+22
`security`	-	112	+112
`securityOss`	-	12	+12
`securitySolution`	-	1296	+1296
`share`	-	123	+123
`snapshotRestore`	-	23	+23
`spaces`	-	106	+106
`spacesOss`	-	72	+72
`stackAlerts`	-	4	+4
`taskManager`	-	52	+52
`telemetry`	-	42	+42
`telemetryCollectionManager`	-	29	+29
`telemetryCollectionXpack`	-	1	+1
`telemetryManagementSection`	-	14	+14
`timelines`	-	882	+882
`triggersActionsUi`	-	237	+237
`uiActions`	-	127	+127
`uiActionsEnhanced`	-	205	+205
`urlForwarding`	-	15	+15
`usageCollection`	-	57	+57
`visTypeTimeseries`	-	10	+10
`visualizations`	-	247	+247
total			+19295

References to deprecated APIs

id	before	after	diff
`actions`	-	8	+8
`alerting`	-	32	+32
`apm`	-	7	+7
`canvas`	-	51	+51
`cases`	-	151	+151
`crossClusterReplication`	-	2	+2
`dashboard`	-	128	+128
`dashboardEnhanced`	-	10	+10
`dataEnhanced`	-	53	+53
`dataVisualizer`	-	16	+16
`discover`	-	102	+102
`discoverEnhanced`	-	19	+19
`embeddable`	-	2	+2
`encryptedSavedObjects`	-	2	+2
`fleet`	-	89	+89
`globalSearch`	-	4	+4
`graph`	-	2	+2
`indexLifecycleManagement`	-	2	+2
`indexManagement`	-	12	+12
`infra`	-	292	+292
`lens`	-	160	+160
`lists`	-	9	+9
`maps`	-	592	+592
`ml`	-	140	+140
`observability`	-	34	+34
`presentationUtil`	-	2	+2
`savedObjects`	-	6	+6
`savedObjectsManagement`	-	18	+18
`savedObjectsTaggingOss`	-	5	+5
`security`	-	2	+2
`securitySolution`	-	800	+800
`stackAlerts`	-	104	+104
`timelines`	-	76	+76
`transform`	-	16	+16
`uptime`	-	11	+11
`urlDrilldown`	-	18	+18
`visTypeTimeseries`	-	12	+12
`visualizations`	-	32	+32
total			+3021

History

💚 Build #141023 succeeded 0e8b261

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* chore(NA): first custom rules for jsts_transpiler * chore(NA): update jsts_transpiler macro * chore(NA): moving @elastic/datemath to babel transpiler * chore(NA): change gitignore rules for bazel

kibanamachine · 2021-07-27T20:47:35Z

💚 Backport successful

Status	Branch	Result
✅	7.14
✅	7.x

The backport PRs will be merged automatically after passing CI.

…06920) * chore(NA): first custom rules for jsts_transpiler * chore(NA): update jsts_transpiler macro * chore(NA): moving @elastic/datemath to babel transpiler * chore(NA): change gitignore rules for bazel Co-authored-by: Tiago Costa <[email protected]>

…06921) * chore(NA): first custom rules for jsts_transpiler * chore(NA): update jsts_transpiler macro * chore(NA): moving @elastic/datemath to babel transpiler * chore(NA): change gitignore rules for bazel Co-authored-by: Tiago Costa <[email protected]>

* chore(NA): first custom rules for jsts_transpiler * chore(NA): update jsts_transpiler macro * chore(NA): moving @elastic/datemath to babel transpiler * chore(NA): change gitignore rules for bazel

mistic added 3 commits July 27, 2021 13:23

chore(NA): first custom rules for jsts_transpiler

6286ebd

chore(NA): update jsts_transpiler macro

c3b0b95

chore(NA): moving @elastic/datemath to babel transpiler

0e8b261

mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.14.1 labels Jul 27, 2021

mistic requested review from tylersmalley and jbudz July 27, 2021 14:52

mistic requested review from a team as code owners July 27, 2021 14:52

jbudz reviewed Jul 27, 2021

View reviewed changes

packages/elastic-datemath/BUILD.bazel Show resolved Hide resolved

jbudz approved these changes Jul 27, 2021

View reviewed changes

tylersmalley reviewed Jul 27, 2021

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

tylersmalley reviewed Jul 27, 2021

View reviewed changes

src/dev/bazel/jsts_transpiler.bzl Show resolved Hide resolved

mistic added 2 commits July 27, 2021 19:24

Merge remote-tracking branch 'upstream/master' into transpile-elastic…

71de16f

…-datemath-with-babel

chore(NA): change gitignore rules for bazel

3d02c66

tylersmalley approved these changes Jul 27, 2021

View reviewed changes

tsullivan approved these changes Jul 27, 2021

View reviewed changes

mistic enabled auto-merge (squash) July 27, 2021 19:35

mistic merged commit 1b8d8d1 into elastic:master Jul 27, 2021

kibanamachine mentioned this pull request Jul 27, 2021

[7.14] chore(NA): moving @elastic/datemath to babel transpiler (#106860) #106920

Merged

kibanamachine mentioned this pull request Jul 27, 2021

[7.x] chore(NA): moving @elastic/datemath to babel transpiler (#106860) #106921

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(NA): moving @elastic/datemath to babel transpiler #106860

chore(NA): moving @elastic/datemath to babel transpiler #106860

mistic commented Jul 27, 2021

elasticmachine commented Jul 27, 2021

jbudz left a comment

tsullivan left a comment

kibanamachine commented Jul 27, 2021

API count

References to deprecated APIs

kibanamachine commented Jul 27, 2021

chore(NA): moving @elastic/datemath to babel transpiler #106860

chore(NA): moving @elastic/datemath to babel transpiler #106860

Conversation

mistic commented Jul 27, 2021

elasticmachine commented Jul 27, 2021

jbudz left a comment

Choose a reason for hiding this comment

tsullivan left a comment

Choose a reason for hiding this comment

kibanamachine commented Jul 27, 2021

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Any counts in public APIs

Async chunks

Public APIs missing exports

Page load bundle

API count

References to deprecated APIs

History

kibanamachine commented Jul 27, 2021

💚 Backport successful