Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-docs] raise memory limit again #107065

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jul 28, 2021

In #106735 I raised the memory limit of node scripts/build_api_docs for PRs and hourly jobs, but forgot that baseline jobs use a different script. This PR updates the memory limit in both places because looking at the results it seems that raising the limit to 8000 helped, but didn't eliminate OOM issues. The numbers on PRs look really good, with only one failure in a PR which ran after the memory limit was increased:

image

(only includes successful jobs, x-axis is based on the time when the baseline jobs used completed, the yellow line shows where we merged the memory limit increase)

The results of baseline and hourly jobs looks similar:
image

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0 labels Jul 28, 2021
@spalger spalger requested a review from brianseeders July 28, 2021 18:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Contributor

@brianseeders brianseeders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you also mind going ahead and making the change in .buildkite/scripts/steps/on_merge_ts_refs_api_docs.sh as well?

@spalger spalger requested a review from a team as a code owner July 28, 2021 18:23
@spalger spalger enabled auto-merge (squash) July 28, 2021 18:23
@spalger spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 28, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit dfb1b61 into elastic:master Jul 28, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 28, 2021
* [api-docs] raise memory limit again

* update buildkite script too

Co-authored-by: spalger <[email protected]>
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.14 Commit could not be cherrypicked due to conflicts
7.x

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 107065

@spalger spalger deleted the implement/raise-docs-api-script-memory-usage-again branch July 28, 2021 20:50
spalger pushed a commit to spalger/kibana that referenced this pull request Jul 28, 2021
* [api-docs] raise memory limit again

* update buildkite script too

Co-authored-by: spalger <[email protected]>
# Conflicts:
#	test/scripts/jenkins_baseline.sh
spalger pushed a commit that referenced this pull request Jul 28, 2021
* [api-docs] raise memory limit again

* update buildkite script too

Co-authored-by: spalger <[email protected]>
# Conflicts:
#	test/scripts/jenkins_baseline.sh
kibanamachine added a commit that referenced this pull request Jul 28, 2021
* [api-docs] raise memory limit again

* update buildkite script too

Co-authored-by: spalger <[email protected]>

Co-authored-by: Spencer <[email protected]>
Co-authored-by: spalger <[email protected]>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
* [api-docs] raise memory limit again

* update buildkite script too

Co-authored-by: spalger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants