Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Archive Migration] x-pack..discover/feature_controls/security #107156

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented Jul 29, 2021

Migrate x-pack..discover/feature_controls/security

Delete x-pack/test/functional/es_archives/discover/feature_controls/security.
Use x-pack/test/functional/fixtures/kbn_archiver/discover/feature_controls/security instead.
Update test(s) to use the kbnarchive.

Partially resolves: #102552

Migrate x-pack..discover/feature_controls/security
@wayneseymour wayneseymour added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0 labels Jul 29, 2021
@wayneseymour wayneseymour requested a review from LeeDr July 29, 2021 15:32
@wayneseymour wayneseymour marked this pull request as ready for review July 30, 2021 09:17
Signed-off-by: Tre' Seymour <[email protected]>
@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@wayneseymour wayneseymour requested a review from marius-dr July 30, 2021 14:05
Copy link
Member

@marius-dr marius-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@wayneseymour
Copy link
Member Author

Maybe blocked on: possible checks reporter error, see in slack

Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code reviewed and Jenkins results.

Please update the description to describe the es_archiver to kbn_archiver change

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wayneseymour wayneseymour merged commit 837eca1 into master Aug 3, 2021
@wayneseymour wayneseymour deleted the esarchiver-migration/xpack-discover-feature_controls-security branch August 3, 2021 09:37
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 107156

wayneseymour added a commit to wayneseymour/kibana that referenced this pull request Aug 3, 2021
…ic#107156)

* [Archive Migration] x-pack..discover/feature_controls/security

Migrate x-pack..discover/feature_controls/security

* Drop fields stanza.

Signed-off-by: Tre' Seymour <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/test/functional/es_archives/discover/feature_controls/security/mappings.json
wayneseymour added a commit that referenced this pull request Aug 3, 2021
…) (#107508)

* [Archive Migration] x-pack..discover/feature_controls/security

Migrate x-pack..discover/feature_controls/security

* Drop fields stanza.

Signed-off-by: Tre' Seymour <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/test/functional/es_archives/discover/feature_controls/security/mappings.json
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
…ic#107156)

* [Archive Migration] x-pack..discover/feature_controls/security

Migrate x-pack..discover/feature_controls/security

* Drop fields stanza.

Signed-off-by: Tre' Seymour <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[meta] Migrate .kibana esArchives to kbnArchiver
4 participants