chore(NA): moving @kbn/server-route-repository to babel transpiler #107571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
Pinging @elastic/apm-ui (Team:apm) |
jbudz
approved these changes
Aug 3, 2021
dgieselaar
reviewed
Aug 4, 2021
| ReturnOf, | ||
| RouteRepositoryClient, | ||
| ServerRouteRepository, | ||
| ServerRoute, | ||
| } from '@kbn/server-route-repository'; | ||
| import { formatRequest } from '@kbn/server-route-repository/target/format_request'; | ||
| // @ts-expect-error |
There was a problem hiding this comment.
can you leave a comment as to what kind of error this is?
There was a problem hiding this comment.
@dgieselaar are we okay to move on here?
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
dgieselaar
approved these changes
Aug 5, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 5, 2021
…lastic#107571) * chore(NA): moving @kbn/server-route-repository to babel transpiler * chore(NA): update types
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 5, 2021
…lastic#107571) * chore(NA): moving @kbn/server-route-repository to babel transpiler * chore(NA): update types
kibanamachine
added a commit
that referenced
this pull request
Aug 5, 2021
…107571) (#107716) * chore(NA): moving @kbn/server-route-repository to babel transpiler * chore(NA): update types Co-authored-by: Tiago Costa <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Aug 5, 2021
…107571) (#107715) * chore(NA): moving @kbn/server-route-repository to babel transpiler * chore(NA): update types Co-authored-by: Tiago Costa <[email protected]>
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
…lastic#107571) * chore(NA): moving @kbn/server-route-repository to babel transpiler * chore(NA): update types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step forward on #69706
That PR moves the @kbn/server-route-repository from using tsc compiler to babel transpiler to produce the js outputs.