[perf-testing] send detailed APM data from report generation #107592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
tylersmalley
approved these changes
Aug 4, 2021
spalger
added
the
auto-backport
|
@elasticmachine merge upstream |
mshustov
reviewed
Aug 9, 2021
| config.globalLabels = Object.fromEntries( | ||
| process.env.ELASTIC_APM_GLOBAL_LABELS.split(',').map((p) => { | ||
| const [key, ...val] = p.split('='); | ||
| return [key, val.join('=')]; |
There was a problem hiding this comment.
why we need this join? in what cases val might be an array with length > 1?
There was a problem hiding this comment.
If the value includes an =
vigneshshanmugam
approved these changes
Aug 9, 2021
mshustov
approved these changes
Aug 9, 2021
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Aug 11, 2021
…#107592) Co-authored-by: spalger <[email protected]> # Conflicts: # x-pack/scripts/functional_tests.js
spalger
pushed a commit
that referenced
this pull request
Aug 11, 2021
#108257) Co-authored-by: spalger <[email protected]> # Conflicts: # x-pack/scripts/functional_tests.js
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107702
Adds an FTR config which produces a PDF report of a dashboard in order to report APM data from dashboard and reporting so we can get an idea of how stable this data is over time, and help us understand how we might use it to power development metrics.