[RAC] [Alerts] Add highlight to building block alerts #107727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machadoum
force-pushed
the
siem-rac-building-blocks-alets
branch
from
45ecb67 to
709a730
Compare
machadoum
added
v7.15.0
v8.0.0
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
machadoum
added
release_note:enhancement
auto-backport
machadoum
force-pushed
the
siem-rac-building-blocks-alets
branch
from
4435dea to
62bd6d5
Compare
| > | ||
| {i18n.ADDITIONAL_FILTERS_ACTIONS} | ||
| </UtilityBarAction> | ||
| <AditionalFiltersAction |
There was a problem hiding this comment.
Thanks for putting this in here!
| @@ -260,3 +222,63 @@ export const AlertsUtilityBar = React.memo( | |||
| prevProps.showBuildingBlockAlerts === nextProps.showBuildingBlockAlerts && | |||
| prevProps.showOnlyThreatIndicatorAlerts === nextProps.showOnlyThreatIndicatorAlerts | |||
| ); | |||
|
|
|||
| export const AditionalFiltersAction = ({ | |||
There was a problem hiding this comment.
👌🏾 Thanks for making this it's own component. I would just say it might be useful in the future to separate each of these filters into their own files, and then export each of them from the index so this file doesn't creep up in size
| <EventsContainerLoading | ||
| data-timeline-id={id} | ||
| data-test-subj={`events-container-loading-${loading}`} | ||
| > | ||
| <EuiFlexGroup gutterSize="none" justifyContent="flexEnd"> | ||
| <UpdatedFlexItem grow={false} show={!loading}> | ||
| <LastUpdatedAt updatedAt={updatedAt} /> |
There was a problem hiding this comment.
Making a self note to move this to the top level as part of #107923
michaelolo24
approved these changes
Aug 10, 2021
machadoum
force-pushed
the
siem-rac-building-blocks-alets
branch
from
62bd6d5 to
203db22
Compare
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/dashboard/panel_context_menu·ts.dashboard app using legacy data dashboard panel context menu on an expanded panel "before all" hook: and add one panel and save to put dashboard in "view" mode for "context menu actions are hidden in view mode"Standard OutStack TraceMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @machadoum |
💔 Backport failed
To backport manually run: |
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Aug 10, 2021
* [rac] [Alerts] Add highlight to building block alerts * Pull back 'additional filters' button to t-grid # Conflicts: # x-pack/plugins/security_solution/public/detections/components/alerts_table/index.tsx
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FYI: The parallel bar layout couldn't be implemented because
EuiDataGriddoesn't allow wrapping a row with a component. elastic/eui#4401Checklist
Delete any items that are not applicable to this PR.