Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data cleanup] unify serializable state #107745

Merged
merged 16 commits into from
Aug 10, 2021
Merged

[Data cleanup] unify serializable state #107745

merged 16 commits into from
Aug 10, 2021

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Aug 5, 2021 •
edited
Loading

Summary

Part of #107638

  • Replaces multiple definitions of SerializableState with a single definition in @kbn/utility-types.
  • Moved JsonObject and JsonArray to @kbn/utility-types.
  • Removed Serializable from core @elastic/kibana-core
  • Changed a bunch of imports

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@lizozom lizozom added v8.0.0 Team:AppServices release_note:skip Skip the PR/issue when compiling release notes v7.15.0 labels Aug 5, 2021
@lizozom lizozom self-assigned this Aug 5, 2021
@lizozom lizozom requested a review from a team August 5, 2021 13:11
@lizozom lizozom requested review from a team as code owners August 5, 2021 13:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@botelastic botelastic bot added Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) labels Aug 5, 2021
@lizozom lizozom requested a review from ppisljar August 5, 2021 13:11
alisonelizabeth
alisonelizabeth approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES UI changes LGTM (ingest node pipelines and ILM)

@lizozom
Copy link
Contributor Author

lizozom commented Aug 6, 2021

@elasticmachine merge upstream

@lizozom
Copy link
Contributor Author

lizozom commented Aug 9, 2021

@elasticmachine merge upstream

kertal
kertal approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KibanaApp owned code LGTM, just change of types, didn't test

@lizozom lizozom requested review from a team as code owners August 9, 2021 12:55
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Aug 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

mshustov
mshustov approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@mshustov mshustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for the core changes

ThomThomson
ThomThomson approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team changes LGTM! Type changes only, so I didn't test it.

@lizozom lizozom requested a review from a team as a code owner August 9, 2021 14:13
YulNaumenko
YulNaumenko approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting changes LGTM.

cjcenizal
cjcenizal approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack Management code changes to ILM and Ingest Node Pipelines locators LGTM. Didn't test locally.

ppisljar
ppisljar approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 952 953 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.7MB 1.7MB +1.6KB
Unknown metric groups

API count

id before after diff
kibanaUtils 600 597 -3

API count missing comments

id before after diff
kibanaUtils 406 404 -2

Non-exported public API item count

id before after diff
core 31 30 -1
data 52 51 -1
expressions 5 4 -1
total -3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lizozom

@lizozom
Copy link
Contributor Author

lizozom commented Aug 10, 2021

I'm skipping a couple of approvals as they are just a package name change.

@lizozom lizozom merged commit 204efae into elastic:master Aug 10, 2021
@lizozom lizozom added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 10, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 10, 2021
@lizozom @kibanamachine
[Data cleanup] unify serializable state (elastic#107745)
409439f 
* Use Serializable from package

* Rename to align with core

* fix

* more replacements

* docssss

* fix

* Move it to @kbn/utility-types and remove core export

* buildy build

* tests

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Aug 10, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 10, 2021
@kibanamachine @lizozom
[Data cleanup] unify serializable state (#107745) (#108020)
32ebd0a 
* Use Serializable from package

* Rename to align with core

* fix

* more replacements

* docssss

* fix

* Move it to @kbn/utility-types and remove core export

* buildy build

* tests

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Liza Katz <[email protected]>
@gmmorris gmmorris added the technical debt Improvement of the software architecture and operational architecture label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

@mshustov mshustov mshustov approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@darnautov darnautov darnautov approved these changes

@ppisljar ppisljar ppisljar approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees

@lizozom lizozom

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability technical debt Improvement of the software architecture and operational architecture v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.