Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[file_upload] include caused_by field for import failures #107907

Merged
merged 5 commits into from
Aug 10, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 9, 2021

Closes #107335

Capture cause_by during import to show users all available information as to why a feature failed import.

Screen Shot 2021-08-09 at 8 47 57 AM

@nreese nreese added release_note:fix [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.15.0 labels Aug 9, 2021
@nreese nreese requested a review from thomasneirynck August 9, 2021 14:54
@nreese nreese requested a review from a team as a code owner August 9, 2021 14:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nreese
Copy link
Contributor Author

nreese commented Aug 9, 2021

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Aug 9, 2021

@elasticmachine merge upstream

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very helpful!

@nreese nreese added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 9, 2021
@nreese
Copy link
Contributor Author

nreese commented Aug 9, 2021

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Aug 10, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

API count

id before after diff
fileUpload 128 129 +1

API count missing comments

id before after diff
fileUpload 128 129 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 37a97b4 into elastic:master Aug 10, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 12, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 107907 or prevent reminders by adding the backport:skip label.

@nreese
Copy link
Contributor Author

nreese commented Aug 12, 2021

autobackport did not work for this PR, so manually created a backport

7.x backport #108454

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 12, 2021
nreese added a commit that referenced this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:fix v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] Features not being imported from valid GeoJson files
5 participants