Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CTI] add hover to threat summary items on alert summary flyout #108996

Merged
merged 1 commit into from
Aug 17, 2021
Merged

[CTI] add hover to threat summary items on alert summary flyout #108996

merged 1 commit into from
Aug 17, 2021

Conversation

ecezalp
Copy link
Contributor

@ecezalp ecezalp commented Aug 17, 2021

Summary

Adds feature in which hovering on threat summary item now shows the action menu (on the side). Previously only hovering on the empty space where the action menu was hidden displayed the action menu.

Screen Shot 2021-08-17 at 4 32 57 PM

@ecezalp ecezalp added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed Feature:RAC label obsolete Team: CTI v7.15.0 labels Aug 17, 2021
@ecezalp ecezalp requested review from rylnd, angorayc, nkhristinin, michaelolo24 and a team August 17, 2021 20:39
@ecezalp ecezalp self-assigned this Aug 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ecezalp ecezalp enabled auto-merge (squash) August 17, 2021 21:40
rylnd
rylnd approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the code, saw the hover action appear as expected. LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.5MB 6.5MB +38.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ecezalp

@ecezalp ecezalp merged commit 448ada6 into elastic:master Aug 17, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 17, 2021
@ecezalp @kibanamachine
[CTI] add hover to threat summary items on alert summary flyout (elas…
23a47f4 
…tic#108996)
@kibanamachine kibanamachine mentioned this pull request Aug 17, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 18, 2021
@kibanamachine @ecezalp
[CTI] add hover to threat summary items on alert summary flyout (#108996
a53cf02 
) (#109018)

Co-authored-by: Ece Özalp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylnd rylnd rylnd approved these changes

@angorayc angorayc Awaiting requested review from angorayc

@nkhristinin nkhristinin Awaiting requested review from nkhristinin

@michaelolo24 michaelolo24 Awaiting requested review from michaelolo24

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:RAC label obsolete release_note:skip Skip the PR/issue when compiling release notes Team: CTI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ecezalp @elasticmachine @kibanamachine @rylnd