Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Separate useUrlParams hooks for APM/Uptime #109579

Merged
merged 1 commit into from
Aug 25, 2021
Merged

[APM] Separate useUrlParams hooks for APM/Uptime #109579

merged 1 commit into from
Aug 25, 2021

Conversation

dgieselaar
Copy link
Member

Summary

Adds a separate useUxUrlParams hook, that allows us to remove properties from useUrlParams without affecting the UX app.

@dgieselaar dgieselaar added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Aug 22, 2021
@dgieselaar dgieselaar added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 24, 2021
@dgieselaar dgieselaar marked this pull request as ready for review August 24, 2021 10:35
@dgieselaar dgieselaar requested review from a team as code owners August 24, 2021 10:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Aug 24, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1618 1619 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.4MB 4.4MB +1.3KB

History

  • 💚 Build #148055 succeeded 928dfebab79e6f723faee642bf78fd5fd1ca13f3
  • 💚 Build #147572 succeeded 66def56616cf0a936ae83352cee4351a2a3ca144

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dominiqueclarke
dominiqueclarke approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX changes and smoke tests LGTM

@dgieselaar dgieselaar merged commit 64d9cc3 into elastic:master Aug 25, 2021
@dgieselaar dgieselaar deleted the ux-url-params branch August 25, 2021 06:42
@kibanamachine kibanamachine mentioned this pull request Aug 25, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 25, 2021
@dgieselaar @kibanamachine
[APM] Separate useUrlParams hooks for APM/Uptime (elastic#109579)
769240e
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 25, 2021
@kibanamachine @dgieselaar
[APM] Separate useUrlParams hooks for APM/Uptime (#109579) (#109997)
16c7fb7 
Co-authored-by: Dario Gieselaar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dgieselaar @elasticmachine @kibanamachine @sorenlouv @dominiqueclarke