Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off api changes for app services and remove legacy docs for App Services plugins #109927

Conversation

stacey-gammon
Copy link
Contributor

While we aren't turning the requirement to build docs for the new system until 8.0, App Services team is okay with removing these. I just hit the command in a PR and it was annoying, so I decided to remove it.

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also can delete files likes src/plugins/data/public/public.api.md (if they are not used in new docs system)

@stacey-gammon stacey-gammon marked this pull request as ready for review August 25, 2021 12:10
@stacey-gammon stacey-gammon requested a review from a team as a code owner August 25, 2021 12:10
@stacey-gammon stacey-gammon requested a review from a team as a code owner August 25, 2021 12:13
…08-24-turn-off-api-changes-for-app-services
@stacey-gammon stacey-gammon added release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 labels Aug 25, 2021
@Dosant Dosant self-requested a review August 25, 2021 13:48
…08-24-turn-off-api-changes-for-app-services
@stacey-gammon stacey-gammon enabled auto-merge (squash) August 25, 2021 18:37
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stacey-gammon stacey-gammon merged commit e307be9 into elastic:master Aug 26, 2021
mattkime pushed a commit to mattkime/kibana that referenced this pull request Aug 26, 2021
…Services plugins (elastic#109927)

* Turn off legacy docs build script for app services plugins

* Remove legacy docs

* remove all *.api.md (minus core)
@mattkime
Copy link
Contributor

I went ahead and did the backport since I'm running into backport merge conflicts.

mattkime added a commit that referenced this pull request Aug 27, 2021
…Services plugins (#109927) (#110378)

* Turn off legacy docs build script for app services plugins

* Remove legacy docs

* remove all *.api.md (minus core)

Co-authored-by: Stacey Gammon <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants