-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data] Update esaggs function to use count aggregation by default #110095
Conversation
Pinging @elastic/kibana-app-services (Team:AppServices) |
Pinging @elastic/kibana-presentation (Team:Presentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes on Canvas LGTM
Summary
This pull-request resolves #67525 by providing the default value for the
aggs
argument. Apart from that, it fixes the data table element in canvas to use column id instead of the column name since the name and id returned by theesaggs
function are different.Previously, the
esaggs
function didn't work without providing at least one value in theaggs
argument. That bug was caused by an incorrect default value which was an empty array. The updated default value should not break any of the existing expressions since that wasn't working before.The change can be tested in canvas using the following expression:
Checklist
For maintainers