Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip tests on 7.15 branch #110310

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/functional/apps/dashboard/dashboard_filtering.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await security.testUser.restoreDefaults();
});

describe('adding a filter that excludes all data', () => {
describe.skip('adding a filter that excludes all data', () => {
before(async () => {
await populateDashboard();
await addFilterAndRefresh();
Expand Down
10 changes: 5 additions & 5 deletions test/functional/apps/discover/_data_grid_doc_table.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});

// flaky https://github.com/elastic/kibana/issues/94889
it.skip('should show popover with expanded cell content by click on expand button', async () => {
it('should show popover with expanded cell content by click on expand button', async () => {
log.debug('open popover with expanded cell content to get json from the editor');
const documentCell = await dataGrid.getCellElement(1, 3);
await documentCell.click();
Expand All @@ -79,7 +79,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(popoverJson).to.be(flyoutJson);
});

describe('expand a document row', function () {
describe.skip('expand a document row', function () {
const rowToInspect = 1;

it('should expand the detail row when the toggle arrow is clicked', async function () {
Expand All @@ -105,7 +105,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});
// skipping for this backport because it's flaky, will resolve in master
it.skip('should show allow adding columns from the detail panel', async function () {
it('should show allow adding columns from the detail panel', async function () {
await retry.try(async function () {
await dataGrid.clickRowToggle({ isAnchorRow: false, rowIndex: rowToInspect - 1 });
await dataGrid.getDetailsRows();
Expand All @@ -132,7 +132,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});

describe('add and remove columns', function () {
describe.skip('add and remove columns', function () {
const extraColumns = ['phpmemory', 'ip'];

afterEach(async function () {
Expand All @@ -142,7 +142,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
}
});

it('should add more columns to the table', async function () {
it.skip('should add more columns to the table', async function () {
for (const column of extraColumns) {
await PageObjects.discover.clearFieldSearchInput();
await PageObjects.discover.findFieldByName(column);
Expand Down
2 changes: 1 addition & 1 deletion test/functional/apps/discover/_discover.ts
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {

describe('time zone switch', () => {
// skipping this until we get an elastic-chart alternative to check the ticks value
it.skip('should show ticks in the correct time zone after switching', async function () {
it('should show ticks in the correct time zone after switching', async function () {
await kibanaServer.uiSettings.replace({ 'dateFormat:tz': 'America/Phoenix' });
await PageObjects.common.navigateToApp('discover');
await PageObjects.header.awaitKibanaChrome();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const PageObjects = getPageObjects(['common', 'timePicker', 'discover']);

// Failing: See https://github.com/elastic/kibana/issues/107057
describe.skip('indexpattern without timefield', () => {
describe('indexpattern without timefield', () => {
before(async () => {
await security.testUser.setRoles(['kibana_admin', 'kibana_timefield']);
await esArchiver.loadIfNeeded(
Expand Down
2 changes: 1 addition & 1 deletion test/functional/apps/management/_runtime_fields.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default function ({ getService, getPageObjects }) {
const testSubjects = getService('testSubjects');

// FLAKY: https://github.com/elastic/kibana/issues/95376
describe.skip('runtime fields', function () {
describe('runtime fields', function () {
this.tags(['skipFirefox']);

before(async function () {
Expand Down
8 changes: 4 additions & 4 deletions test/functional/apps/management/_scripted_fields.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export default function ({ getService, getPageObjects }) {
'timePicker',
]);

describe('scripted fields', function () {
describe.skip('scripted fields', function () {
this.tags(['skipFirefox']);

before(async function () {
Expand Down Expand Up @@ -154,7 +154,7 @@ export default function ({ getService, getPageObjects }) {
});

//add a test to sort numeric scripted field
it('should sort scripted field value in Discover', async function () {
it.skip('should sort scripted field value in Discover', async function () {
await testSubjects.click(`docTableHeaderFieldSort_${scriptedPainlessFieldName}`);
// after the first click on the scripted field, it becomes secondary sort after time.
// click on the timestamp twice to make it be the secondary sort key.
Expand Down Expand Up @@ -340,7 +340,7 @@ export default function ({ getService, getPageObjects }) {

//add a test to sort boolean
//existing bug: https://github.com/elastic/kibana/issues/75519 hence the issue is skipped.
it.skip('should sort scripted field value in Discover', async function () {
it('should sort scripted field value in Discover', async function () {
await testSubjects.click(`docTableHeaderFieldSort_${scriptedPainlessFieldName2}`);
// after the first click on the scripted field, it becomes secondary sort after time.
// click on the timestamp twice to make it be the secondary sort key.
Expand Down Expand Up @@ -415,7 +415,7 @@ export default function ({ getService, getPageObjects }) {

//add a test to sort date scripted field
//https://github.com/elastic/kibana/issues/75711
it.skip('should sort scripted field value in Discover', async function () {
it('should sort scripted field value in Discover', async function () {
await testSubjects.click(`docTableHeaderFieldSort_${scriptedPainlessFieldName2}`);
// after the first click on the scripted field, it becomes secondary sort after time.
// click on the timestamp twice to make it be the secondary sort key.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default function ({ getService, getPageObjects }) {
const SCRIPTED_FIELD_NAME = 'myScriptedField';

// FLAKY: https://github.com/elastic/kibana/issues/89475
describe.skip('scripted fields preview', () => {
describe('scripted fields preview', () => {
before(async function () {
await browser.setWindowSize(1200, 800);
await PageObjects.settings.createIndexPattern();
Expand Down
2 changes: 1 addition & 1 deletion test/functional/apps/management/_test_huge_fields.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default function ({ getService, getPageObjects }) {
const PageObjects = getPageObjects(['common', 'home', 'settings']);

// FLAKY: https://github.com/elastic/kibana/issues/89031
describe.skip('test large number of fields', function () {
describe('test large number of fields', function () {
this.tags(['skipCloud']);

const EXPECTED_FIELD_COUNT = '10006';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {

// FLAKY: https://github.com/elastic/kibana/issues/96997
// FLAKY: https://github.com/elastic/kibana/issues/100372
describe.skip('chained controls', function () {
describe('chained controls', function () {
this.tags('includeFirefox');

before(async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const comboBox = getService('comboBox');

// FLAKY: https://github.com/elastic/kibana/issues/98974
describe.skip('dynamic options', () => {
describe('dynamic options', () => {
before(async () => {
await PageObjects.visualize.initTests();
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default function ({ getPageObjects, getService }) {
const PageObjects = getPageObjects(['common', 'dashboard', 'visualize', 'lens']);

// FLAKY: https://github.com/elastic/kibana/issues/102366
describe.skip('empty dashboard', function () {
describe('empty dashboard', function () {
before(async () => {
await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/logstash_functional');
await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/lens/basic');
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/apps/grok_debugger/home_page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
});

// This test will need to be fixed.
it.skip('applies the correct CSS classes', async () => {
it('applies the correct CSS classes', async () => {
const grokPattern = '\\[(?:-|%{NUMBER:bytes:int})\\]';

await PageObjects.grokDebugger.setPatternInput(grokPattern);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context';

export default function ({ loadTestFile }: FtrProviderContext) {
// FLAKY: https://github.com/elastic/kibana/issues/35932
describe.skip('feature controls', function () {
describe('feature controls', function () {
this.tags('skipFirefox');
loadTestFile(require.resolve('./infrastructure_security'));
loadTestFile(require.resolve('./infrastructure_spaces'));
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/apps/infra/home_page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
});

// FLAKY: https://github.com/elastic/kibana/issues/106660
describe.skip('Saved Views', () => {
describe('Saved Views', () => {
before(() => esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs'));
after(() => esArchiver.unload('x-pack/test/functional/es_archives/infra/metrics_and_logs'));
it('should have save and load controls', async () => {
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/apps/infra/metrics_explorer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
});

// FLAKY: https://github.com/elastic/kibana/issues/106651
describe.skip('Saved Views', () => {
describe('Saved Views', () => {
before(() => esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs'));
after(() => esArchiver.unload('x-pack/test/functional/es_archives/infra/metrics_and_logs'));
describe('save functionality', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const appsMenu = getService('appsMenu');

// FLAKY: https://github.com/elastic/kibana/issues/38414
describe.skip('spaces feature controls', () => {
describe('spaces feature controls', () => {
before(async () => {
PageObjects.maps.setBasePath('/s/custom_space');
});
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/apps/maps/layer_errors.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export default function ({ getPageObjects }) {
// Flaky test on cloud and windows when run against a snapshot build of 7.11.
// https://github.com/elastic/kibana/issues/91043

it.skip('should diplay error message in layer panel', async () => {
it('should diplay error message in layer panel', async () => {
const errorMsg = await PageObjects.maps.getLayerErrorText(LAYER_NAME);
expect(errorMsg).to.equal(
`Unable to find EMS tile configuration for id: ${MISSING_EMS_ID}. Kibana is unable to access Elastic Maps Service. Contact your system administrator.`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ export default function ({ getService }: FtrProviderContext) {

for (const testData of testDataList) {
// FLAKY: https://github.com/elastic/kibana/issues/93188
describe.skip(`${testData.suiteTitle}`, function () {
describe(`${testData.suiteTitle}`, function () {
before(async () => {
await ml.navigation.navigateToMl();
await ml.navigation.navigateToDataFrameAnalytics();
Expand Down
4 changes: 2 additions & 2 deletions x-pack/test/functional/apps/monitoring/elasticsearch/nodes.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default function ({ getService, getPageObjects }) {
const nodesList = getService('monitoringElasticsearchNodes');
const esClusterSummaryStatus = getService('monitoringElasticsearchSummaryStatus');

describe('Elasticsearch nodes listing', function () {
describe.skip('Elasticsearch nodes listing', function () {
// FF issue: https://github.com/elastic/kibana/issues/35551
this.tags(['skipFirefox']);

Expand Down Expand Up @@ -260,7 +260,7 @@ export default function ({ getService, getPageObjects }) {
});

// FLAKY: https://github.com/elastic/kibana/issues/100438
describe.skip('with only online nodes', () => {
describe('with only online nodes', () => {
const { setup, tearDown } = getLifecycleMethods(getService, getPageObjects);

before(async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default function ({ getService, getPageObjects }) {
const nodesList = getService('monitoringElasticsearchNodes');
const esClusterSummaryStatus = getService('monitoringElasticsearchSummaryStatus');

describe('Elasticsearch nodes listing mb', function () {
describe.skip('Elasticsearch nodes listing mb', function () {
// FF issue: https://github.com/elastic/kibana/issues/35551
this.tags(['skipFirefox']);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default function ({ getService, getPageObjects }) {
const overview = getService('monitoringElasticsearchOverview');
const esClusterSummaryStatus = getService('monitoringElasticsearchSummaryStatus');

describe('Elasticsearch overview', () => {
describe.skip('Elasticsearch overview', () => {
const { setup, tearDown } = getLifecycleMethods(getService, getPageObjects);

before(async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default function ({ getService, getPageObjects }) {
const overview = getService('monitoringElasticsearchOverview');
const esClusterSummaryStatus = getService('monitoringElasticsearchSummaryStatus');

describe('Elasticsearch overview mb', () => {
describe.skip('Elasticsearch overview mb', () => {
const { setup, tearDown } = getLifecycleMethods(getService, getPageObjects);

before(async () => {
Expand Down
4 changes: 2 additions & 2 deletions x-pack/test/functional/apps/monitoring/time_filter.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,15 @@ export default function ({ getService, getPageObjects }) {
});

// FLAKY: https://github.com/elastic/kibana/issues/48910
it.skip('should send another request when clicking Refresh', async () => {
it('should send another request when clicking Refresh', async () => {
await testSubjects.click('querySubmitButton');
const isLoading = await PageObjects.header.isGlobalLoadingIndicatorVisible();
expect(isLoading).to.be(true);
});

// TODO: [cr] I'm not sure this test is any better than the above one, we might need to rely solely on unit tests
// for this functionality
it.skip('should send another request when changing the time picker', async () => {
it('should send another request when changing the time picker', async () => {
await PageObjects.timePicker.setAbsoluteRange(
'Aug 15, 2016 @ 21:00:00.000',
'Aug 16, 2016 @ 00:00:00.000'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await PageObjects.observability.expectForbidden();
});

it.skip(`create new case returns a 403`, async () => {
it(`create new case returns a 403`, async () => {
await PageObjects.common.navigateToUrl('observabilityCases', 'create', {
shouldUseHashForSubUrl: false,
});
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/apps/security/users.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default function ({ getService, getPageObjects }) {
const log = getService('log');

// FAILING ES PROMOTION: https://github.com/elastic/kibana/issues/96001
describe.skip('users', function () {
describe('users', function () {
before(async () => {
log.debug('users');
await PageObjects.settings.navigateTo();
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/apps/spaces/enter_space.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default function enterSpaceFunctonalTests({
const PageObjects = getPageObjects(['security', 'spaceSelector']);

// FLAKY: https://github.com/elastic/kibana/issues/100570
describe.skip('Enter Space', function () {
describe('Enter Space', function () {
this.tags('includeFirefox');
before(async () => {
await esArchiver.load('x-pack/test/functional/es_archives/spaces/enter_space');
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/apps/spaces/spaces_selection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default function spaceSelectorFunctionalTests({
]);

// FLAKY: https://github.com/elastic/kibana/issues/99581
describe.skip('Spaces', function () {
describe('Spaces', function () {
this.tags('includeFirefox');
describe('Space Selector', () => {
before(async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default function upgradeAssistantFunctionalTests({
const testSubjects = getService('testSubjects');

// Updated for the hiding of the UA UI.
describe('Upgrade Checkup', function () {
describe.skip('Upgrade Checkup', function () {
this.tags('skipFirefox');

before(async () => {
Expand All @@ -40,11 +40,11 @@ export default function upgradeAssistantFunctionalTests({
});
});

it.skip('allows user to navigate to upgrade checkup', async () => {
it('allows user to navigate to upgrade checkup', async () => {
await PageObjects.upgradeAssistant.navigateToPage();
});

it.skip('allows user to toggle deprecation logging', async () => {
it('allows user to toggle deprecation logging', async () => {
log.debug('expect initial state to be ON');
expect(await PageObjects.upgradeAssistant.deprecationLoggingEnabledLabel()).to.be('On');
expect(await PageObjects.upgradeAssistant.isDeprecationLoggingEnabled()).to.be(true);
Expand All @@ -67,15 +67,15 @@ export default function upgradeAssistantFunctionalTests({
});
});

it.skip('allows user to open cluster tab', async () => {
it('allows user to open cluster tab', async () => {
await PageObjects.upgradeAssistant.navigateToPage();
await PageObjects.upgradeAssistant.clickTab('cluster');
expect(await PageObjects.upgradeAssistant.issueSummaryText()).to.be(
'You have no cluster issues.'
);
});

it.skip('allows user to open indices tab', async () => {
it('allows user to open indices tab', async () => {
await PageObjects.upgradeAssistant.navigateToPage();
await PageObjects.upgradeAssistant.clickTab('indices');
expect(await PageObjects.upgradeAssistant.issueSummaryText()).to.be(
Expand Down