Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing docs reference from elasticsearch.ssl.cert to certificate #11037

Merged
merged 2 commits into from
Apr 7, 2017
Merged

Fixing docs reference from elasticsearch.ssl.cert to certificate #11037

merged 2 commits into from
Apr 7, 2017

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Apr 5, 2017

#9823 deprecated elasticsearch.ssl.cert in place of elasticsearch.ssl.certificate, but a reference in the docs was missed as kindly pointed out by @Jarpy

@kobelb kobelb added the v5.3.1 label Apr 5, 2017
@kobelb kobelb added v5.3.0 v5.4.0 v6.0.0 bug Fixes for quality problems that affect the customer experience review Team:Docs labels Apr 5, 2017
@kobelb
Copy link
Contributor Author

kobelb commented Apr 5, 2017

jenkins test this

@ninaspitfire
Copy link
Contributor

Github won't let me leave a line comment beyond the bounds of the patch, but there's also a suspicious looking elasticsearch.tribe.ssl.cert on line 79.

@kobelb
Copy link
Contributor Author

kobelb commented Apr 6, 2017

Nice catch @Jarpy, the elasticsearch.tribe.ssl docs weren't changed for a number of the settings, I've made the necessary corrections.

@epixa epixa added v5.3.2 and removed v5.3.1 labels Apr 6, 2017
@ninaspitfire
Copy link
Contributor

Thanks! Good docs for these are very useful over at elastic/kibana-docker, I assure you.

@kobelb kobelb merged commit f398dd2 into elastic:master Apr 7, 2017
@kobelb kobelb deleted the elasticsearch-ssl-cert-doc branch April 7, 2017 11:59
kobelb added a commit that referenced this pull request Apr 7, 2017
@kobelb
Fixing docs reference from elasticsearch.ssl.cert to certificate (#11037
1c853b1 
)

* Fixing docs reference from elasticsearch.ssl.cert to certificate

* Fixing elasticsearch.tribe.ssl doc sections
kobelb added a commit that referenced this pull request Apr 7, 2017
@kobelb
Fixing docs reference from elasticsearch.ssl.cert to certificate (#11037
71eda16 
)

* Fixing docs reference from elasticsearch.ssl.cert to certificate

* Fixing elasticsearch.tribe.ssl doc sections
@kobelb
Copy link
Contributor Author

kobelb commented Apr 7, 2017

Backported

5.x - 1c853b1
5.3 - 71eda16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience review Team:Docs v5.3.0 v5.3.2 v5.4.0 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kobelb @ninaspitfire @jbudz @epixa