Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Stop loading js-yaml in main plugin bundle #111169

Merged
merged 2 commits into from
Sep 7, 2021

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented Sep 3, 2021

Summary

Related to #95863

Removes the imports for js-yaml in x-pack/plugins/fleet/common to avoid loading this heavy library on page load and wait until it's actually needed. In the future we may want to consider using a smaller library or moving this logic to the server-side (in a secure fashion).

cc @hop-dev I know you were interested in this area. There's still a lot of room for additional improvement to get under 100kb, this was just the biggest chunk of low hanging fruit and was blocking my progress on #111131

@joshdover joshdover added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Sep 6, 2021
@joshdover joshdover added auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 v8.0.0 labels Sep 6, 2021
@joshdover joshdover marked this pull request as ready for review September 6, 2021 14:15
@joshdover joshdover requested review from a team as code owners September 6, 2021 14:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1066 1069 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 800.1KB 1020.4KB ⚠️ +220.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 454.7KB 234.8KB -220.0KB
Unknown metric groups

API count

id before after diff
fleet 1167 1170 +3

History

  • 💛 Build #151010 was flaky 1f81dfb93fcfa793d1534173f68827edfb5fb0d8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joshdover joshdover enabled auto-merge (squash) September 6, 2021 17:11
Copy link
Contributor

@hop-dev hop-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants