-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Stop loading js-yaml in main plugin bundle #111169
Conversation
1f81dfb
to
dc4147c
Compare
Pinging @elastic/fleet (Team:Fleet) |
💚 Build SucceededMetrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Co-authored-by: Josh Dover <[email protected]>
Summary
Related to #95863
Removes the imports for
js-yaml
inx-pack/plugins/fleet/common
to avoid loading this heavy library on page load and wait until it's actually needed. In the future we may want to consider using a smaller library or moving this logic to the server-side (in a secure fashion).cc @hop-dev I know you were interested in this area. There's still a lot of room for additional improvement to get under 100kb, this was just the biggest chunk of low hanging fruit and was blocking my progress on #111131