-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ x-pack Functional] unskipping home_page.ts test. #113312
[ x-pack Functional] unskipping home_page.ts test. #113312
Conversation
had 15 failures (out of 100 executions) |
Trying to fix the Flaky test failure.
|
💔 Build Failed
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Last run of Flaky test runner failed once in 100 executions. Added a retry loop- around the setPatternInput(grokPattern) and kicked off the Flaky test runner again. https://kibana-ci.elastic.co/view/All/job/kibana+flaky-test-suite-runner/1963/
|
@cuff-links this si the failure:
Trying to fix this. It has been flaky. - Plz suggest. Failure screenshot : cc @LeeDr |
This third test in the home_page suite should remain skipped as it is very flaky. It's my opinion that this test would be better suited for something like a React Jest test or a component integration test in Jest. I think that would be better than testing CSS classes in a selenium based test, especially for something like syntax highlighting. |
I will be closing this PR in leiu of @cuff-links comments above. |
ref PR: #110310
Un-skipping an individual test in
kibana/x-pack/test/functional/apps/grok_debugger/home_page.ts