Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ x-pack Functional] unskipping home_page.ts test. #113312

Closed

Conversation

rashmivkulkarni
Copy link
Contributor

ref PR: #110310

Un-skipping an individual test in kibana/x-pack/test/functional/apps/grok_debugger/home_page.ts

@rashmivkulkarni rashmivkulkarni added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Grok Debugger Dev Tools Grok Debugger feature auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 28, 2021
@rashmivkulkarni rashmivkulkarni self-assigned this Sep 28, 2021
@rashmivkulkarni
Copy link
Contributor Author

@rashmivkulkarni rashmivkulkarni mentioned this pull request Sep 28, 2021
38 tasks
@LeeDr
Copy link

LeeDr commented Sep 28, 2021

https://kibana-ci.elastic.co/view/All/job/kibana+flaky-test-suite-runner/1958/

had 15 failures (out of 100 executions)

@rashmivkulkarni
Copy link
Contributor Author

Trying to fix the Flaky test failure.

  • added a await PageObjects.common.sleep(5000); in the test to see if the previous test before the failure allows the next test to start clean. ( have pushed in the changes with describe.only ( commit with --no-verify flag) . This will fail the CI with ESLint failures, but need to see the stability of this test on Flaky test runner for 100 executions. https://kibana-ci.elastic.co/view/All/job/kibana+flaky-test-suite-runner/1963/

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 29, 2021

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rashmivkulkarni

@rashmivkulkarni
Copy link
Contributor Author

rashmivkulkarni commented Sep 29, 2021

Last run of Flaky test runner failed once in 100 executions. Added a retry loop- around the setPatternInput(grokPattern) and kicked off the Flaky test runner again. https://kibana-ci.elastic.co/view/All/job/kibana+flaky-test-suite-runner/1963/

      await retry.try(async () => {
        await PageObjects.grokDebugger.setPatternInput(grokPattern);
      });

@rashmivkulkarni
Copy link
Contributor Author

rashmivkulkarni commented Sep 30, 2021

@cuff-links this si the failure:

[00:00:26]             │ info Saving page source to: /dev/shm/workspace/parallel/4/kibana/x-pack/test/functional/failure_debug/html/Grok Debugger App Grok Debugger applies the correct CSS classes.html
[00:00:26]             └- ✖ fail: Grok Debugger App Grok Debugger applies the correct CSS classes
[00:00:26]             │      StaleElementReferenceError: stale element reference: element is not attached to the page document
[00:00:26]             │   (Session info: headless chrome=94.0.4606.61)
[00:00:26]             │       at Object.throwDecodedError (/dev/shm/workspace/parallel/4/kibana/node_modules/selenium-webdriver/lib/error.js:550:15)
[00:00:26]             │       at parseHttpResponse (/dev/shm/workspace/parallel/4/kibana/node_modules/selenium-webdriver/lib/http.js:565:13)
[00:00:26]             │       at Executor.execute (/dev/shm/workspace/parallel/4/kibana/node_modules/selenium-webdriver/lib/http.js:491:26)
[00:00:26]             │       at runMicrotasks (<anonymous>)
[00:00:26]             │       at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:00:26]             │       at Task.exec (/dev/shm/workspace/parallel/4/kibana/test/functional/services/remote/prevent_parallel_calls.ts:28:20)
[00:00:26]             │ 
[00:00:26]             │ 

https://kibana-ci.elastic.co/view/All/job/kibana+flaky-test-suite-runner/1968/testReport/Chrome%20X-Pack%20UI%20Functional%20Tests/x-pack_test_functional_apps_grok_debugger_home_page%C2%B7ts/Kibana_Pipeline___agent_1___Grok_Debugger_App_Grok_Debugger_applies_the_correct_CSS_classes_2/

Trying to fix this. It has been flaky. - Plz suggest. Failure screenshot :
Screen Shot 2021-09-30 at 12 14 27 PM

cc @LeeDr

@cuff-links
Copy link
Contributor

This third test in the home_page suite should remain skipped as it is very flaky. It's my opinion that this test would be better suited for something like a React Jest test or a component integration test in Jest. I think that would be better than testing CSS classes in a selenium based test, especially for something like syntax highlighting.

@rashmivkulkarni
Copy link
Contributor Author

I will be closing this PR in leiu of @cuff-links comments above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Grok Debugger Dev Tools Grok Debugger feature release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants