Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

un-skip maps/feature_controls/maps_spaces.ts functional test #113656

Merged
merged 20 commits into from
Oct 20, 2021

Conversation

rashmivkulkarni
Copy link
Contributor

Ref PR: #110310
fixes: #38414

running with a describe.only - locally passing many times.

@rashmivkulkarni rashmivkulkarni added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation test_xpack_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes 7.16 candidate labels Oct 1, 2021
@rashmivkulkarni rashmivkulkarni requested a review from a team as a code owner October 1, 2021 18:00
@rashmivkulkarni rashmivkulkarni self-assigned this Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@rashmivkulkarni
Copy link
Contributor Author

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@LeeDr LeeDr mentioned this pull request Oct 4, 2021
38 tasks
@LeeDr
Copy link

LeeDr commented Oct 5, 2021

Flaky Test Runner : https://kibana-ci.elastic.co/view/All/job/kibana+flaky-test-suite-runner/1976/

Just adding a note here that the flaky test runner did fail 73 out of 100 tries.

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni rashmivkulkarni added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 6, 2021
@rashmivkulkarni
Copy link
Contributor Author

rashmivkulkarni commented Oct 6, 2021

@rashmivkulkarni
Copy link
Contributor Author

irrelevant failure on previous Ci run.
@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

https://kibana-ci.elastic.co/view/All/job/kibana+flaky-test-suite-runner/2064/ ( good Flaky test runner run - 100 executions)

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rashmivkulkarni

@rashmivkulkarni
Copy link
Contributor Author

@LeeDr / @nreese - another time review please. Good on CI and Flaky test runner .
https://kibana-ci.elastic.co/view/All/job/kibana+flaky-test-suite-runner/2064/ ( good Flaky test runner run - 100 executions)

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Its nice to turn this test back on!

@nreese nreese changed the title un-skipping a maps test. un-skip maps/feature_controls/maps_spaces.ts functional test Oct 20, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rashmivkulkarni

Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code review and test results only

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.16

This backport PR will be merged automatically after passing CI.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 22, 2021
@rashmivkulkarni rashmivkulkarni removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 22, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 25, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

4 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Nov 1, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v7.16.0 v8.0.0
Projects
None yet
5 participants