-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
un-skip maps/feature_controls/maps_spaces.ts functional test #113656
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
Flaky Test Runner : https://kibana-ci.elastic.co/view/All/job/kibana+flaky-test-suite-runner/1976/ |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Just adding a note here that the flaky test runner did fail 73 out of 100 tries. |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
irrelevant failure on previous Ci run. |
https://kibana-ci.elastic.co/view/All/job/kibana+flaky-test-suite-runner/2064/ ( good Flaky test runner run - 100 executions) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
@LeeDr / @nreese - another time review please. Good on CI and Flaky test runner . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Its nice to turn this test back on!
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - code review and test results only
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
4 similar comments
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
#115871) Co-authored-by: Rashmi Kulkarni <[email protected]>
Ref PR: #110310
fixes: #38414
running with a
describe.only
- locally passing many times.