-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Fix group layering #114346
[Canvas] Fix group layering #114346
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Pinging @elastic/kibana-presentation (Team:Presentation) |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
@elasticmachine merge upstream |
1 similar comment
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Dr. Robertson
Will also fix #46782 |
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* Fix group layering * Fixes incorrect z-layers for elements at 90deg Co-authored-by: Kibana Machine <[email protected]>
* Fix group layering * Fixes incorrect z-layers for elements at 90deg Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Corey Robertson <[email protected]>
* Fix group layering * Fixes incorrect z-layers for elements at 90deg Co-authored-by: Kibana Machine <[email protected]>
* Fix group layering * Fixes incorrect z-layers for elements at 90deg Co-authored-by: Kibana Machine <[email protected]>
Fixes #114073
Fixes #46782
Elements and groups are combined into a single array, and then each is given a z layer value based on the index in that array.
So all groups were "higher" than every single element. So any single element could be over every element in the group, but the group would be selected if you click on it.
This change gives groups a z layer value equal to the highest z layer value of its children.
This also works for a group that is made up of other groups. The parent group will get the z-layer of the child group which gets the z-layer of it's highest child.
Edit....
Turns out that wasn't what was causing the bug on the original issue. That was caused by an element rotated to 90 or -90deg also getting an incorrect z layer in aero elastic. I've pushed a commit to fix that issue as well.