-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nit][pre-req] Strongly-type Shipper and Category #114412
[nit][pre-req] Strongly-type Shipper and Category #114412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for shipper change, but I would remove the change to categories. IntegrationCategory
was already strongly typed, and this change adds a duplication of data-structures (basically, we would now require two lists now, once as an array and once as a map).
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/runtime_fields·ts.lens app lens runtime fields should be able to add runtime field and use itStandard Out
Stack Trace
Metrics [docs]Public APIs missing comments
Page load bundle
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Co-authored-by: Clint Andrew Hall <[email protected]>
Summary
As titled. As other folks register their integrations, the
Shipper
andIntegrationCategory
need to be 1/ strongly-typed, and 2/ mapped to a title for display.