-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds an API for managing saved objects #11632
Merged
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
b250ad9
Adds saved object API
621fd48
Fixes typo
197a5e4
Remove kibana from saved object API path
005b029
Nests document in doc element for ES
8b0c32d
Resolves tests for update API
f6dd705
Prevent leaking of ES query to API
af59a5c
Adds version to saved objects API
a8e3279
Return version for searches
915c7df
Removes ability to specify id on object creation
6c0cfb6
Adds version to update response
1835163
Create uses ES index action
a2d9877
Allow per_page of 0 for total
cbbeff7
Cleans up SavedObjectClient.find and uses camelCases
986a73a
Underscores private variables
b916a7a
Removes request dependency on SavedObjectClient
5fa37cc
Allows for replacement of Promise library for Ng
280003d
Use ES source filtering
110628e
Seperate attributes
6148eac
search_fields should be snake case
9eb2efc
$http Response returns data attribute
639feb9
Embed object array as saved_objects instead of data
bfadd34
Review feedback
ef193a2
Removes delete boolean response
a397738
Merge remote-tracking branch 'upstream/master' into saved-objects-api
d44aae1
Renames data attribute to body
5a152da
Merge remote-tracking branch 'upstream/master' into saved-objects-api
4454f85
Restores savedDashboardRegister
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Renames data attribute to body
Signed-off-by: Tyler Smalley <[email protected]>
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arguments having different meaning based on other arguments is pretty confusing, and this is unnecessary since the second argument to
SavedObjectsClient#_getUrl()
already allows setting query string parameters. This should probably just throw an error like "body is not allowed onGET
requests"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. We're now throwing an error if you attempt to pass body with GET and using
_getUrl
to format the query parameters.