Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] remove cruft #116986

Merged
merged 1 commit into from
Nov 1, 2021
Merged

[Maps] remove cruft #116986

merged 1 commit into from
Nov 1, 2021

Conversation

thomasneirynck
Copy link
Contributor

Removes some unused params from the Maps code base.

@thomasneirynck thomasneirynck added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes labels Nov 1, 2021
@thomasneirynck thomasneirynck requested a review from a team as a code owner November 1, 2021 16:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 41.3KB 41.2KB -88.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nreese
nreese approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning up
code review

@thomasneirynck thomasneirynck merged commit 7bd984b into elastic:main Nov 1, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 3, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 116986 or prevent reminders by adding the backport:skip label.

@thomasneirynck thomasneirynck added the backport:skip This commit does not require backporting label Nov 3, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasneirynck @elasticmachine @kibanamachine @nreese