[Cases] Fix remark stringify version to match remark parse #119995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
release_note:fix
v7.15.3
v7.16.1
v8.0.0
v8.1.0
Team:Threat Hunting
x-pack/plugins/cases/server/saved_object_types/migrations/comments.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/cases/server/saved_object_types/migrations/comments.test.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/cases/server/saved_object_types/migrations/comments.ts
Outdated
Show resolved
Hide resolved
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-cases (Team:Threat Hunting:Cases) |
jonathan-buttner
added
release_note:skip
|
@elasticmachine merge upstream |
tylersmalley
approved these changes
Dec 3, 2021
3 tasks
|
@elasticmachine merge upstream |
cnasikas
approved these changes
Dec 6, 2021
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 8, 2021
…19995) * match parse and stringify version. try/catch added * Adding tests and refactoring logError * Adding relative path to core and kibana utils * remark curstom serializers adapted to version 8 * add error logging to comments migration * Adding tests for mergeMigrationFunctionMap logging Co-authored-by: Jonathan Buttner <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
kibanamachine
added a commit
that referenced
this pull request
Dec 8, 2021
…120843) * match parse and stringify version. try/catch added * Adding tests and refactoring logError * Adding relative path to core and kibana utils * remark curstom serializers adapted to version 8 * add error logging to comments migration * Adding tests for mergeMigrationFunctionMap logging Co-authored-by: Jonathan Buttner <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Sergi Massaneda <[email protected]> Co-authored-by: Jonathan Buttner <[email protected]>
jonathan-buttner
added a commit
that referenced
this pull request
Dec 8, 2021
…120849) * match parse and stringify version. try/catch added * Adding tests and refactoring logError * Adding relative path to core and kibana utils * remark curstom serializers adapted to version 8 * add error logging to comments migration * Adding tests for mergeMigrationFunctionMap logging Co-authored-by: Jonathan Buttner <[email protected]> Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/cases/server/saved_object_types/migrations/comments.ts Co-authored-by: Sergi Massaneda <[email protected]>
jonathan-buttner
pushed a commit
to jonathan-buttner/kibana
that referenced
this pull request
Dec 9, 2021
…19995) * match parse and stringify version. try/catch added * Adding tests and refactoring logError * Adding relative path to core and kibana utils * remark curstom serializers adapted to version 8 * add error logging to comments migration * Adding tests for mergeMigrationFunctionMap logging Co-authored-by: Jonathan Buttner <[email protected]> Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # package.json # x-pack/plugins/cases/common/utils/markdown_plugins/utils.test.ts # x-pack/plugins/cases/server/saved_object_types/migrations/comments.test.ts # x-pack/plugins/cases/server/saved_object_types/migrations/comments.ts # x-pack/plugins/cases/server/saved_object_types/migrations/user_actions.test.ts # x-pack/plugins/cases/server/saved_object_types/migrations/user_actions.ts # x-pack/plugins/cases/server/saved_object_types/migrations/utils.test.ts # x-pack/plugins/cases/server/saved_object_types/migrations/utils.ts # yarn.lock
jonathan-buttner
added a commit
that referenced
this pull request
Dec 13, 2021
…19995) (#120916) * [Cases] Fix remark stringify version to match remark parse (#119995) * match parse and stringify version. try/catch added * Adding tests and refactoring logError * Adding relative path to core and kibana utils * remark curstom serializers adapted to version 8 * add error logging to comments migration * Adding tests for mergeMigrationFunctionMap logging Co-authored-by: Jonathan Buttner <[email protected]> Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # package.json # x-pack/plugins/cases/common/utils/markdown_plugins/utils.test.ts # x-pack/plugins/cases/server/saved_object_types/migrations/comments.test.ts # x-pack/plugins/cases/server/saved_object_types/migrations/comments.ts # x-pack/plugins/cases/server/saved_object_types/migrations/user_actions.test.ts # x-pack/plugins/cases/server/saved_object_types/migrations/user_actions.ts # x-pack/plugins/cases/server/saved_object_types/migrations/utils.test.ts # x-pack/plugins/cases/server/saved_object_types/migrations/utils.ts # yarn.lock * Adding tests and fixing yarn lock * Using correct migration * fixing eslint issues * Removing redudent tests Co-authored-by: Sergi Massaneda <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
…19995) * match parse and stringify version. try/catch added * Adding tests and refactoring logError * Adding relative path to core and kibana utils * remark curstom serializers adapted to version 8 * add error logging to comments migration * Adding tests for mergeMigrationFunctionMap logging Co-authored-by: Jonathan Buttner <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119509
This PR fixes an issue where github style tables within a case cause an upgrade migration to 7.15 to fail and blocks the upgrade from completing. The issue is that
remark-stringifywas initially added at version9.xwhich uses a newer version ofremarksuch that the github style tables are removed fromremarkand placed in a separate plugin calledremark-gfm. To fix this issue we are downgradingremark-stringifyto match the version ofremark-parsewhich is8.0.3.In additional to this we are also wrapping the parsing logic in a
try/catchto prevent any future errors from preventing and upgrade from completing.Release Notes
Fixes a bug in the Cases upgrade migration that was preventing upgrades from completing. This was due to Github Flavored Markdown not being supported in the Cases comments.