[Fleet] Allow empty strings for required text fields in package policies #123610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hop-dev
added
release_note:fix
v8.0.0
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
joshdover
reviewed
Jan 24, 2022
x-pack/plugins/fleet/common/services/validate_package_policy.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Page load bundle
To update your PR or re-run it, just comment with: cc @hop-dev |
joshdover
approved these changes
Jan 24, 2022
kpollich
approved these changes
Jan 24, 2022
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 25, 2022
…ies (elastic#123610) * Allow empty strings for required text fields in package policies * make empty yaml check more explicit (cherry picked from commit bf2626f)
kibanamachine
added a commit
that referenced
this pull request
Jan 25, 2022
…ies (#123610) (#123717) * Allow empty strings for required text fields in package policies * make empty yaml check more explicit (cherry picked from commit bf2626f) Co-authored-by: Mark Hopkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #123596.
If a text variable is marked as required in the package manifest, we will now allow empty strings to be supplied as a valid value. I have opted to keep it as invalid to have an empty yaml variable.
Test
Unit tests updated, but choose any package with a required text value and provide an empty string when creating a package policy.