Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gauge] Transparent background #126014

Merged
merged 4 commits into from
Feb 22, 2022
Merged

[Gauge] Transparent background #126014

merged 4 commits into from
Feb 22, 2022

Conversation

Kuznietsov
Copy link
Contributor

Summary

Completes part of the issue

  • Added transparent background.

Screenshots:

Screenshot 2022-02-18 at 09 42 23

@Kuznietsov Kuznietsov added loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. backport:skip This commit does not require backporting NeededFor:Canvas v8.2.0 labels Feb 18, 2022
@Kuznietsov Kuznietsov self-assigned this Feb 18, 2022
@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Kuznietsov Kuznietsov marked this pull request as ready for review February 21, 2022 14:50
@Kuznietsov Kuznietsov requested a review from a team as a code owner February 21, 2022 14:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@Kuznietsov Kuznietsov requested a review from stratoula February 21, 2022 16:06
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionGauge 8.9KB 8.9KB +37.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

stratoula
stratoula approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, I tested it locally in Chrome with dark and light theme.

@Kuznietsov
Copy link
Contributor Author

@stratoula, @mbondyra, thanks for your reviews.

@Kuznietsov Kuznietsov merged commit fa4e115 into elastic:main Feb 22, 2022
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
@Kuznietsov @kibanamachine @lucasfcosta
[Gauge] Transparent background (elastic#126014)
456a551 
* Added transparent background

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@mbondyra mbondyra mbondyra approved these changes

@crob611 crob611 Awaiting requested review from crob611

@VladLasitsa VladLasitsa Awaiting requested review from VladLasitsa

@alexwizp alexwizp Awaiting requested review from alexwizp

Assignees

@Kuznietsov Kuznietsov

Labels
backport:skip This commit does not require backporting impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kuznietsov @elasticmachine @kibana-ci @mbondyra @stratoula @kibanamachine