hasData service

[shivindera]

Summary

As part of the improved UX experience, we'd like to standardize the empty state view check for all apps. For that we have created a new service inside dataViews plugin that checks the below states:

• hasESData: () => Promise; // Check to see if ES data exists
• hasDataView: () => Promise; // Check to see if any data view exists (primitive or user created)
• hasUserDataView: () => Promise; // Check to see if user created data views exist

This is solving issue - #124019

Checklist

Delete any items that are not applicable to this PR.

• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[majagrubic]

Thanx for taking this on. Added a few early comments.

[mattkime]

A few notes but otherwise everything is moving along nicely

[elasticmachine]

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

[Dosant]

Some nit suggestions

[jbudz]

limits.yml LGTM

[majagrubic]

Service signature looks good for the shared-ux use-case! I had a quick pass through the code, no major concerns there.

[mattkime]

What do we have for tests? Are there existing tests that verify this functionality? Some simple unit tests might be helpful as well.

[mattkime]

looks good, nice work!

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 20004f2
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
dataViews	44	46	+2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
dataViews	645	711	+66

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
dataViewEditor	114.5KB	114.5KB	+5.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
dataViews	10	15	+5

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
dataViews	40.5KB	42.3KB	+1.8KB

Unknown metric groups

API count

id	before	after	diff
dataViews	797	863	+66

References to deprecated APIs

id	before	after	diff
dashboard	81	78	-3
lens	237	234	-3
visualizations	114	111	-3
total			-9

Unreferenced deprecated APIs

id	before	after	diff
dataViews	0	2	+2

History

• 💚 Build #30960 succeeded 02a41e9
• 💔 Build #28430 failed c6af299
• 💔 Build #28344 failed dae01c2
• 💔 Build #28170 failed 76653ae

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

⚪ Backport skipped

The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.

Manual backport

To create the backport manually run:

node scripts/backport --pr 127068

Questions ?

Please refer to the Backport tool documentation